fix dos profile #2425
Merged
fix dos profile #2425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urohit011
approved these changes
Sep 10, 2024
| self.want.profile, self.want.partition) | ||
| ) | ||
| uri = "https://{0}:{1}/mgmt/tm/security/dos/profile/{2}/application/{3}".format( | ||
| # if not self.profile_exists(): |
There was a problem hiding this comment.
Please remove the commented out code here and on line 1241, rest looks good.
| @@ -1213,11 +1238,18 @@ def update_on_device(self): | |||
| raise F5ModuleError(resp.content) | |||
|
|
|||
| def remove_from_device(self): | |||
| uri = "https://{0}:{1}/mgmt/tm/security/dos/profile/{2}/application/{3}".format( | |||
| # uri = "https://{0}:{1}/mgmt/tm/security/dos/profile/{2}/application/{3}".format( | |||
There was a problem hiding this comment.
Plaese remove the commented code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2419
fixes #2421