Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend energy scan mode in NXenergydispersion #127

Merged
merged 5 commits into from
Jan 8, 2024
Merged

Extend energy scan mode in NXenergydispersion #127

merged 5 commits into from
Jan 8, 2024

Conversation

lukaspie
Copy link
Collaborator

@lukaspie lukaspie commented Nov 28, 2023 •
edited
Loading

Initial draft for discussion of energy scan mode of the energy dispersive element.
We need some better description of transmission and jittered/dithered energy scan modes.

Fixes #126

@lukaspie lukaspie added the mpes label Nov 28, 2023
@lukaspie lukaspie mentioned this pull request Nov 28, 2023
Merged
@lukaspie lukaspie marked this pull request as ready for review January 4, 2024 09:36
rettigl
rettigl approved these changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@rettigl rettigl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a suggestion for the missing docstring. I am wonding if we should also add a mode for TOFs. Before we used "fixed", but this has been removed now, and "snapshot" does not really capture this case.

contributed_definitions/NXenergydispersion.nxdl.xml Show resolved Hide resolved
contributed_definitions/NXenergydispersion.nxdl.xml Outdated Show resolved Hide resolved
contributed_definitions/NXenergydispersion.nxdl.xml Outdated Show resolved Hide resolved
contributed_definitions/NXenergydispersion.nxdl.xml Outdated Show resolved Hide resolved
@lukaspie
Copy link
Collaborator Author

lukaspie commented Jan 8, 2024

I think this can be merged unless there is any other open questions.

Regarding the mode for TOFs, I suggest we propose what we have here in the workshop and ask for some more input.

domna
domna approved these changes Jan 8, 2024
View reviewed changes
Copy link

@domna domna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go from my side

@domna domna mentioned this pull request Jan 8, 2024
Open
@lukaspie lukaspie merged commit 46abd51 into mpes-refactor Jan 8, 2024
@lukaspie lukaspie deleted the 126-extend-energy-scan_mode-in-nxenergydispersion branch January 8, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rettigl rettigl rettigl approved these changes

@domna domna domna approved these changes

@Tommaso-Pincelli Tommaso-Pincelli Awaiting requested review from Tommaso-Pincelli

Assignees
No one assigned
Labels
mpes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukaspie @domna @rettigl