#243 Sprint22 Add stigmation correctors, removed unnecessary EM-Base Classes, opened NXcomponent for other techniques #250
Conversation
… source inside tech partner file
There was a problem hiding this comment.
Mostly small questions, but I do have an issue as to how these new base classes are supposed to fit within the NXem ecosystem. Most of the new base classes are not used in NXem (or in the base classes that are specialized within NXem), so how are they supposed to be used in the appdef? As example, searches for NXmonochromator_em and NXcorrector_ax don't show them being cited anywhere else.
EDIT: I see that #251 adds most of them to NXem. Should anyway be checked that they are all cited?
#243 added connections to HMC EMglossary
… NXcomponent for technical components through removing electron microscopy specificity
… should be used for python>=3.12
… replaced all locations where NXaperture_em was used for NXaperture
mkuehbach
changed the title
…more meaty base class NXimage_set, the partner in crime for NXspectrum_set
…asses Fused NXimage_r_set, NXimage_c_set, NXimage_r_set_diff into a single …
Promote component_em to generally usable base class NXcomponent
mkuehbach
changed the title
|
This PR is ready to get merged into fairmat. However, it introduces breaking changes in the data model of some em examples which requires feature updates and fixes to be made in pynxtools-em. Currently, there is vacation time, a basesection sprint is planned to happen right after the vacation time, which should then get all the focus. In summary, there is now a two week gap in which the changes for em can be implemented without introducing breaking changes on the main development line. Therefore, I will close this PR and merge sprint22_corrector into sprint23_em_v3. This branch is a clone of today's fairmat branch such that it can be used to implement and test a specific pynxtools definition version instead of the mainline fairmat. This avoids breaking examples, enables to use the two week gap for an EM sprint. An additional advantage is that also sprint22_microstructure can be merged into sprint23_em_v3 such that the entire package of em and microstructure description related changes can be used in the same pynxtools development. This is relevant because also feature additions of the MTex exporting is planned that require sprint22_microstructure. |
No description provided.