changes for requiredness relaxation, partial names, temperature_env o… #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f SAMPLE in NXoptical_spec, make URLS recommended
|
Not sure, why ther are so many whitespace changes. did not see any of that in VSCode... |
lukaspie
reviewed
Mar 5, 2025
| @@ -780,7 +782,7 @@ NXoptical_spectroscopy(NXobject): | |||
| exists: recommended | |||
| doc: | | |||
| A set of activities that occurred to the sample prior to/during the experiment. | |||
| temperature(NXenvironment): | |||
| temperature_env(NXenvironment): | |||
There was a problem hiding this comment.
Maybe just use NXenvironment/value here for descirbing non-measured temperature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing the nameType=partial(removed from here. Reopend other PR: Name type for opt spec #333)