-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use hdf5 or nexus file in XRD #113
Open
ka-sarthak
wants to merge
85
commits into
main
Choose a base branch
from
write-nexus-section
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,733
−321
Open
Changes from 1 commit
Commits
Show all changes
85 commits
Select commit
Hold shift + click to select a range
03f9668
updated plugin structure
andreaa93 4cd5876
added pynxtools dependency
andreaa93 cf8477a
Apply suggestions from Sarthak's code review
andreaa93 20f671e
ruff linting
andreaa93 7ebc02b
Ruff linting 2
ka-sarthak 0267e34
Apply suggestions from code review
andreaa93 8023fd1
changed xrd parser folder
andreaa93 326ff9e
last fixes and descriptions
andreaa93 7020e31
description of general schema
andreaa93 cc08ba9
changed general package into a module
andreaa93 8de59ec
Implement write nexus section based on the populated nomad archive
ka-sarthak e687c46
Update path of populate_nexus_subsection
ka-sarthak e618170
app def missing. (#108)
RubelMozumder f0828ca
Run Python test action for all PR
ka-sarthak 8db4370
Fix for rebasing issues
ka-sarthak f5fda0f
Use hdf5 references for arrays (#118)
ka-sarthak 75bb246
Adding nexus in ref (#150)
RubelMozumder 1ef1c1b
Move common functionality to resolve_path
ka-sarthak 5b2a4f7
Allow reading with dataset_path alone
ka-sarthak 5dc681c
Allow reading with archive paths
ka-sarthak 680edb0
Never reset the instance variables
ka-sarthak 9f43379
Final file writing when the instance is deleted
ka-sarthak 76452ec
Reduce write_file calls to one
ka-sarthak 94baa75
Fix: set hard links for internal ref
ka-sarthak 4c4d29a
remove del method; fix test
ka-sarthak 618fd77
Combine nexus dataset map
ka-sarthak 63c4926
Ruff
ka-sarthak a59f532
Make Auxiliary file name without raw file ext
ka-sarthak 13b3053
Add cleanup extensions for fixture
ka-sarthak f7bfd8f
Use bool in ELN to control raw file updation
ka-sarthak a88006a
Remove 'file and entry deletion'
ka-sarthak 9e39be7
remove defaults: trigger write if file is missing
ka-sarthak a7b8e07
Minor
ka-sarthak ff15839
Set hdf5 references at add_dataset stage
ka-sarthak 9cddee0
Reset on trigger for main branch PR only
ka-sarthak ad9217c
abstract out set hdf5 ref
ka-sarthak 13e88ee
Comment out nexus, TODOs, docstrings
ka-sarthak 7105d0a
Reprocess nxs entry
ka-sarthak 3825e2c
Handle missing dataset in add step
ka-sarthak de3bd3f
Comment out import
ka-sarthak 0c025dc
Review: sourcery
ka-sarthak 52d720b
Add back non hdf5 result sections
ka-sarthak 196291f
reset quantity shape
ka-sarthak dfc1510
Remove redundant definitions; add overwritten and new ones
ka-sarthak e63ed6d
Minor
ka-sarthak be3e5dc
Hide array_index
ka-sarthak 6c5fc5e
Update class in test
ka-sarthak e9a5ded
Make it optional to supply additional clean up extensions
ka-sarthak 5d5d586
Review: harmonize filename
ka-sarthak 284fd38
Fix
ka-sarthak 48a14f2
fix pynxtools version and a minor fix in nexus part.
RubelMozumder 4bbdeef
Review: Rename plotting sections
ka-sarthak 230dc18
Review: use Dataset model as argument
ka-sarthak 0f0809b
Review: remove redundant variable
ka-sarthak 8101848
Review: use dict comprehension
ka-sarthak 7bf2792
Update doc strings
ka-sarthak 68f9773
Make explicit nexus generation error flag
ka-sarthak d226f3c
Review: renaming
ka-sarthak 01658bc
Take out hdf5 population from normalize to separate methods
ka-sarthak 63c20ea
Move handler to XRayDiffraction
ka-sarthak e378796
Trigger hdf5 handling from XRayDiffraction
ka-sarthak 21ffa42
Update doc for populate_nxdataset_and_attribute func.
RubelMozumder abd3577
Type hinting for datasets; docstring; ruff
ka-sarthak 3c85c88
Use filename directly in read_dataset
ka-sarthak b4d29a9
Use handler as arg for generate plot
ka-sarthak fdb5639
Reordering
ka-sarthak 2ccfca6
Fix
ka-sarthak ea2570e
Backcompatibility: delete results only if they has non-hdf5 definitions
ka-sarthak 17e3cce
Docstrings
ka-sarthak 893969c
Remove method: set_hdf5_reference
ka-sarthak dae1084
Make method private
ka-sarthak 98d8fd2
Remove reading through archive path
ka-sarthak acc81da
Add dataset path normalization in read_dataset; minor
ka-sarthak b959cb1
Move all hdf5 related normalization in ELN normalization
ka-sarthak d2e78f4
Ordering
ka-sarthak 550c834
Move results normalization to `XRayDiffraction`
ka-sarthak 78fd0a2
Use None handler to slim down reprocessing
ka-sarthak 940f907
Return early
ka-sarthak 0b44419
Rename
ka-sarthak 55ff442
Add browser adaptor
ka-sarthak bba0965
Revert pint as type checking import
ka-sarthak 48c1006
Use nexus file
ka-sarthak d4ceb5c
Remove warnings from read_dataset; refactor
ka-sarthak e0166a7
Handle nexus filepath during tests
ka-sarthak e210a69
Ruff
ka-sarthak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Reprocess nxs entry
commit 7105d0acc3db05808d0f15ebae962efd9375a3a3
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get from nx map instead