Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use different numpy and pint versions for different python versions, update ruff #65

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Use different numpy and pint versions for different python versions, update ruff #65

merged 2 commits into from
Jun 19, 2024

Conversation

lukaspie
Copy link
Collaborator

@lukaspie lukaspie commented Jun 19, 2024 •
edited
Loading

Fixes #64

@lukaspie lukaspie force-pushed the np-and-pint-versions branch from 51f0df5 to 8b12b8f Compare June 19, 2024 09:16
@coveralls
Copy link

coveralls commented Jun 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9579354538

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 9431201784: 0.0%
Covered Lines: 20
Relevant Lines: 20
💛 - Coveralls

@lukaspie lukaspie force-pushed the np-and-pint-versions branch from 8b12b8f to bc31c3a Compare June 19, 2024 09:18
@coveralls
Copy link

coveralls commented Jun 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9579415619

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 9431201784: 0.0%
Covered Lines: 20
Relevant Lines: 20
💛 - Coveralls

@lukaspie lukaspie requested review from sherjeelshabih and domna June 19, 2024 09:22
@coveralls
Copy link

coveralls commented Jun 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9579447537

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 9431201784: 0.0%
Covered Lines: 20
Relevant Lines: 20
💛 - Coveralls

@lukaspie lukaspie marked this pull request as ready for review June 19, 2024 09:26
domna
domna reviewed Jun 19, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@domna
Copy link
Collaborator

domna commented Jun 19, 2024

I suggest also to update ruff==0.4.8 and use the numpy ruff plugin: https://numpy.org/doc/stable/numpy_2_0_migration_guide.html#ruff-plugin

@lukaspie lukaspie changed the title Use different numpy and pint versions for different python versions Use different numpy and pint versions for different python versions, update ruff Jun 19, 2024
@coveralls
Copy link

coveralls commented Jun 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9579760191

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 9431201784: 0.0%
Covered Lines: 20
Relevant Lines: 20
💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9579760191

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 9431201784: 0.0%
Covered Lines: 20
Relevant Lines: 20
💛 - Coveralls

domna
domna approved these changes Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@domna domna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukaspie lukaspie merged commit 2cd7b3f into main Jun 19, 2024
7 checks passed
@lukaspie lukaspie deleted the np-and-pint-versions branch June 19, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domna domna domna approved these changes

@sherjeelshabih sherjeelshabih Awaiting requested review from sherjeelshabih

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade numpy and ruff
4 participants
@lukaspie @coveralls @domna @sherjeelshabih