Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow the use of wildcard definitions for the reader tests #476

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

rettigl
Copy link
Collaborator

@rettigl rettigl commented Dec 3, 2024

No description provided.

@rettigl
Copy link
Collaborator Author

rettigl commented Dec 3, 2024

This is needed e.g. for the igor reader that I am currently cleaning up and preparing for here: https://github.com/rettigl/pynxtools-igor

@lukaspie
Copy link
Collaborator

lukaspie commented Dec 4, 2024

Quick question: is the igor-reader then supposes to write to any or to none of the application definitions? We should maybe allow only one of these options with this wildcard notation and indicate that in the docs as well.

@rettigl
Copy link
Collaborator Author

rettigl commented Dec 4, 2024

Quick question: is the igor-reader then supposes to write to any or to none of the application definitions? We should maybe allow only one of these options with this wildcard notation and indicate that in the docs as well.

This wildcard notation is anyways supported by the data converter, see

nxdl_name in data_reader.supported_nxdls or "*" in data_reader.supported_nxdls

The Igor reader is intended to read from Igor ibw or pxp files, and allow to write to any appdef, or just NXroot

@lukaspie
Copy link
Collaborator

lukaspie commented Dec 4, 2024

Quick question: is the igor-reader then supposes to write to any or to none of the application definitions? We should maybe allow only one of these options with this wildcard notation and indicate that in the docs as well.

This wildcard notation is anyways supported by the data converter, see

nxdl_name in data_reader.supported_nxdls or "*" in data_reader.supported_nxdls

The Igor reader is intended to read from Igor ibw or pxp files, and allow to write to any appdef, or just NXroot

Ok, makes sense. Feel free to merge.

@rettigl rettigl merged commit d61bc6c into master Dec 4, 2024
16 checks passed
@rettigl rettigl deleted the allow_wildcard_definition_in_reader_test branch December 4, 2024 22:24
@rettigl rettigl mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants