Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not log read_nexus to the console in tests #579

Merged
merged 3 commits into from
Mar 7, 2025
Merged

Conversation

lukaspie
Copy link
Collaborator

@lukaspie lukaspie commented Mar 7, 2025

Printing the whole log only unnecessarily fills up the test log without helping too much. To still see the line-by-line difference, I am now using difflib.

@lukaspie lukaspie marked this pull request as draft March 7, 2025 15:51
@lukaspie lukaspie force-pushed the read-nexus-log-level branch from 4b2c85c to 2478fe7 Compare March 7, 2025 16:22
@lukaspie lukaspie marked this pull request as ready for review March 7, 2025 16:22
@lukaspie lukaspie requested a review from sanbrock March 7, 2025 16:22
Copy link
Collaborator

@sanbrock sanbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukaspie lukaspie merged commit 09fb12d into master Mar 7, 2025
17 checks passed
@lukaspie lukaspie deleted the read-nexus-log-level branch March 7, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants