OpcodeDispatcher: Unify PSHUF{L,H}W implementations #4125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functional change.
Allows the AVX128 implementation to use the same implementation as the 128-bit SSE implementation, because it works per 128-bit lane just like SSE. Is a minor optimization.
|
nice! |
alyssarosenzweig
approved these changes
Oct 21, 2024
lioncash
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MMX, SSE, and AVX were all using different implementations. Unify the three of them.
This is a nop for the MMX and SSE implementation, but this does some minor optimization for the AVX implementation since the SSE path was slightly more optimal.
Fixes #4123