Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more tests as unsupported by vixl #4153

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Conversation

pmatos
Copy link
Collaborator

@pmatos pmatos commented Nov 4, 2024

It seems a form of mrs is unsupported as well as the hint wfe used for pause.

Remove skipping Rounding(Neg|Pos).asm as they are passing.

@pmatos
Copy link
Collaborator Author

pmatos commented Nov 4, 2024

humm, in 32 bits the test is not being skipped... converting to draft so it's not merged.

@pmatos pmatos marked this pull request as draft November 4, 2024 17:35
It seems a form of `mrs` is unsupported as well as the hint `wfe` used for `pause`.
Remove skipping Rounding(Neg|Pos).asm as they are passing.
@pmatos pmatos marked this pull request as ready for review November 4, 2024 17:53
@pmatos
Copy link
Collaborator Author

pmatos commented Nov 4, 2024

Apparently the two tests in that file that were supposed to be skipped, actually pass and they were not being skipped because they missed the Test_32Bit_ prefix. So removed the useless lines.

@Sonicadvance1 Sonicadvance1 merged commit c1db7a7 into FEX-Emu:main Nov 18, 2024
12 checks passed
@pmatos pmatos deleted the VixlSkip branch November 18, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants