FEXCore: Moves ThreadWaiting to the frontend #4179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bylaws
reviewed
Nov 28, 2024
Sonicadvance1
force-pushed
the
move_thread_waiting_start
branch
2 times, most recently
from
7c89cc5 to
4e02baf
Compare
Sonicadvance1
added a commit
to Sonicadvance1/FEX
that referenced
this pull request
Nov 29, 2024
We were using this variable for two things, letting the frontend signal to the backend that it wants to start executing once the thread is created, and also for handling thread pausing. These two features are conflated with one another and actually makes things more confusing. - Move StartRunning/StartPaused to the frontend, because its a construct that only needs to exist in the frontend - Adds a FEX::HLE::ThreadStateObject CV for handling pausing, which only needs to exist for gdbserver Relies on FEX-Emu#4170 and FEX-Emu#4179 being merged first. Which is what the first two commits are from.
Sonicadvance1
added a commit
to Sonicadvance1/FEX
that referenced
this pull request
Nov 29, 2024
We were using this variable for two things, letting the frontend signal to the backend that it wants to start executing once the thread is created, and also for handling thread pausing. These two features are conflated with one another and actually makes things more confusing. - Move StartRunning/StartPaused to the frontend, because its a construct that only needs to exist in the frontend - Adds a FEX::HLE::ThreadStateObject CV for handling pausing, which only needs to exist for gdbserver Relies on FEX-Emu#4170 and FEX-Emu#4179 being merged first. Which is what the first two commits are from.
Sonicadvance1
added a commit
to Sonicadvance1/FEX
that referenced
this pull request
Nov 29, 2024
We were using this variable for two things, letting the frontend signal to the backend that it wants to start executing once the thread is created, and also for handling thread pausing. These two features are conflated with one another and actually makes things more confusing. - Move StartRunning/StartPaused to the frontend, because its a construct that only needs to exist in the frontend - Adds a FEX::HLE::ThreadStateObject CV for handling pausing, which only needs to exist for gdbserver Relies on FEX-Emu#4170 and FEX-Emu#4179 being merged first. Which is what the first two commits are from.
Sonicadvance1
added a commit
to Sonicadvance1/FEX
that referenced
this pull request
Nov 29, 2024
We were using this variable for two things, letting the frontend signal to the backend that it wants to start executing once the thread is created, and also for handling thread pausing. These two features are conflated with one another and actually makes things more confusing. - Move StartRunning/StartPaused to the frontend, because its a construct that only needs to exist in the frontend - Adds a FEX::HLE::ThreadStateObject CV for handling pausing, which only needs to exist for gdbserver Relies on FEX-Emu#4170 and FEX-Emu#4179 being merged first. Which is what the first two commits are from.
lioncash
approved these changes
Nov 29, 2024
Only in one location does the frontend actually care about this, the backend doesn't care at all.
Sonicadvance1
force-pushed
the
move_thread_waiting_start
branch
from
4e02baf to
9f681f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only in one location does the frontend actually care about this, the
backend doesn't care at all.