LinuxEmulation: Ensure syscall wrapper declaration has CpuStateFrame as the first argument #4290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sonicadvance1
changed the title
|
Oof, I assumed the syscall macros covered some minimal signature checking at least, but guess not... Including external references in PRs can help prevent this, as it makes it easier for reviewers to cross-check. The author typically already knows where the reference is, so it would make sense to include it in the description. Besides that, could you reword the commit message to something more factual and informative? |
…as the first argument Otherwise crashes occur.
Sonicadvance1
force-pushed
the
fix_v6.13
branch
from
7f91ea5 to
9858ab7
Compare
Sonicadvance1
changed the title
|
Added more words to the commit message with more meaningful meanings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise crashes occur.