Merge pull request #331 from FFXIV-CombatReborn/SCH-stuff

SCH base changes missed now fixed
FFXIV-CombatReborn · Aug 29, 2024 · 361228a · 361228a
2 parents e204372 + e59b19c
commit 361228a
Showing 1 changed file with 28 additions and 2 deletions.
diff --git a/RotationSolver.Basic/Rotations/Basic/ScholarRotation.cs b/RotationSolver.Basic/Rotations/Basic/ScholarRotation.cs
@@ -69,19 +69,26 @@ static partial void ModifyBioIiPvE(ref ActionSetting setting)
     static partial void ModifyAdloquiumPvE(ref ActionSetting setting)
     {
         setting.StatusFromSelf = false;
-        setting.StatusProvide =
+        setting.TargetStatusProvide =
         [
             StatusID.EukrasianDiagnosis,
             StatusID.EukrasianPrognosis,
             StatusID.Galvanize
         ];
+        setting.IsFriendly = true;
         setting.UnlockedByQuestID = 66633;
     }
 
     static partial void ModifySuccorPvE(ref ActionSetting setting)
     {
         setting.StatusFromSelf = false;
-        setting.StatusProvide = [StatusID.Galvanize];
+        setting.StatusProvide =
+        [
+            StatusID.EukrasianDiagnosis,
+            StatusID.EukrasianPrognosis,
+            StatusID.Galvanize
+        ];
+        setting.IsFriendly = true;
         setting.UnlockedByQuestID = 66634;
         setting.CreateConfig = () => new ActionConfig()
         {
@@ -165,6 +172,7 @@ static partial void ModifyDeploymentTacticsPvE(ref ActionSetting setting)
 
     static partial void ModifyEmergencyTacticsPvE(ref ActionSetting setting)
     {
+        setting.StatusProvide = [StatusID.EmergencyTactics];
         setting.UnlockedByQuestID = 67211;
         setting.IsFriendly = true;
     }
@@ -281,6 +289,12 @@ static partial void ModifyBanefulImpactionPvE(ref ActionSetting setting)
 
     static partial void ModifyConcitationPvE(ref ActionSetting setting)
     {
+        setting.StatusProvide =
+        [
+            StatusID.EukrasianDiagnosis,
+            StatusID.EukrasianPrognosis,
+            StatusID.Galvanize
+        ];
         setting.IsFriendly = true;
         setting.CreateConfig = () => new ActionConfig()
         {
@@ -297,12 +311,24 @@ static partial void ModifySeraphismPvE(ref ActionSetting setting)
     static partial void ModifyManifestationPvE(ref ActionSetting setting)
     {
         setting.ActionCheck = () => Player.HasStatus(true, StatusID.Seraphism);
+        setting.TargetStatusProvide =
+        [
+            StatusID.EukrasianDiagnosis,
+            StatusID.EukrasianPrognosis,
+            StatusID.Galvanize
+        ];
         setting.IsFriendly = true;
     }
 
     static partial void ModifyAccessionPvE(ref ActionSetting setting)
     {
         setting.ActionCheck = () => Player.HasStatus(true, StatusID.Seraphism);
+        setting.StatusProvide =
+        [
+            StatusID.EukrasianDiagnosis,
+            StatusID.EukrasianPrognosis,
+            StatusID.Galvanize
+        ];
         setting.IsFriendly = true;
         setting.CreateConfig = () => new ActionConfig()
         {