Enforce an order for types when fishing #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FISHING_ORDER defines the order in which definitions will be checked when fishing. If a different order is desired, fish for types one at a time.
jafeltra
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Ohhh, interesting that we already had a test that did the opposite. But I guess that makes sense that it was there!
I think technically because FPL is not at a 1.x.y version yet, breaking changes can be introduced in minor version bumps pre-1.0. That said, SUSHI has been using FPL in an official release for a while now, so it probably is worth considering releasing an official 1.x version. Maybe now is our time!
cmoesel
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes task CIMPL-1184.
FISHING_ORDER defines the order in which definitions will be checked when fishing. If a different order is desired, fish for types one at a time.
Given that there was an existing test that specifically checked for the opposite behavior, this probably qualifies as a breaking change. We should keep that in mind when releasing this feature.