Update Node to v18 and update all dependencies #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jafeltra
reviewed
Jan 29, 2024
There was a problem hiding this comment.
This looks pretty good. I tested packing it and using it in SUSHI, and the audit report comes out clean.
One thing that I think can also get updated now is the CI workflow to use Node 18 as well. It looks like the test step uses 16 and 18 but the lint and prettier step only uses 16.
Ahh... Busted! You got me on that one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Node from 16 to 18 now that Node 16 is EOL. It also updates all dependencies. Only chalk could not be updated due to incompatibility with Jest, which was documented in DEPENDENCY-NOTES.md.
Many thanks to @mint-thompson, who already figured out the hard bits when they updated SUSHI's dependencies.
The tests all pass, but you can also test the CLI manually and pack it up then test using SUSHI as well.