Added Test Result Sorting #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…json files produced. Sorting the jsons so that they are produced in a standard order will help with testing in the future . It will be easier to determine when and where changes are made. This push also includes the new sorted outputs.
|
@AkRampersad Can you confirm - does this affect normal Operations responses, or is the sorting only applied when comparing against test cases? |
This sorting is only applied when comparing the test cases. The sorting is found in the |
…runs the function on a JSON with nested dictionaries that are out of order. The other test runs the function on a simple 1 layer json. This commit also has a assertion check in tu.compare_actual_and_expected_output to make sure that the expected output is sorted correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This branch is implementing json sorting for the actual and expected json files produced. Sorting the jsons so that they are produced in a standard order will help with testing in the future . It will be easier to determine when and where changes are made. This push also includes the new sorted outputs.
How Has This Been Tested?
I visually identified that the ordering was correct after it was changed and used online JSON comparison tools to help with this.