Environment Macro Property IO #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robadob
force-pushed
the
env_macro_property_io
branch
from
2f91c49
to
2cc3212
Compare
Robadob
force-pushed
the
env_macro_property_io
branch
13 times, most recently
from
fc1bcac
to
3340dd4
Compare
Robadob
requested review from
mondus and
ptheywood
and removed request for
mondus
Robadob
force-pushed
the
env_macro_property_io
branch
from
3340dd4
to
259f2eb
Compare
ptheywood
requested changes
Aug 31, 2023
There was a problem hiding this comment.
A few trivial comments added, that would be nice (and simple) to address, though not the end of the world to merge without. Can wait till you return from leave.
The change to .cu files made diffing less clear (just git issues), and will mean we have to do more of a breaking change later if we have a non cuda build, but that's going to be breaking either way.
Tests all pass under linux.
This is an API break, so will need documenting in the changelog as such for the next pre-release.
Robadob
force-pushed
the
env_macro_property_io
branch
from
259f2eb
to
f6ab3dd
Compare
Exported as 1D array for simplicity. Also switched CUDAMacroEnvironment from reference to shared_ptr
This special method also supports raw binary IO, for exceptionally large macro propertys unsuitable for xml/json. Added an associated test in suite IOTest3 for each of the formats.
Robadob
force-pushed
the
env_macro_property_io
branch
from
f6ab3dd
to
ad59e2a
Compare
ptheywood
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ended up refactoring much of the internal model state IO interface to make partial import/export possible.
JSONStateWriterwould create an agent object for each agent state, leading to multiple members with the same key.HostMacroPropertydid not use streams to copy data. (C tests still pass after this change)CUDAMacroEnvironmentfrom reference toshared_ptrOf note, macro properties can still not be initialised via
EnvironmentDescriptionorRunPlan.It's a basic interface change (two new methods added to
HostAPIwith no weird types/templates, so only C API tests have been extended/updated.Commits are split cleanly, does not require squash.
Closes #1070