Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose JitifyCache via Python interface. #1151

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Conversation

Robadob
Copy link
Member

@Robadob Robadob commented Nov 20, 2023

Required by FLAMEGPU/ABM_Framework_Comparisons#9

To allow

if "--disable-rtc-cache" in sys.argv:
    rtc_cache = pyflamegpu.JitifyCache.getInstance()
    rtc_cache.useMemoryCache(False)
    rtc_cache.useDiskCache(False)

The changes to JitifyCache.h/.cu are required to suppress a SWIG warning, "Nothing known about jitify::experimental::KernelInstantiation".

This will cause conflicts with #1150

Copy link
Member

@ptheywood ptheywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of test cases to programatically check this is exposed, which it is.

I'll let you (@Robadob) merge this once CI passes, assuming you are happy with my tests.

@Robadob Robadob merged commit 1561815 into master Nov 21, 2023
20 checks passed
@Robadob Robadob deleted the swig_expose_jitifycache branch November 21, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants