Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cmake version deprecations fix #1168

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Cmake version deprecations fix #1168

merged 3 commits into from
Jan 12, 2024

Conversation

ptheywood
Copy link
Member

@ptheywood ptheywood commented Jan 4, 2024 •
edited
Loading

Fixes deprecation notice of removal of cmake_minimum_required <= 3.5 in dependencencies with CMake >= 3.27 (or 3.26.4?).

  • Updates Google test to the latest tagged release
  • Updates rapid json to the most recent version which does not break our method of fetch content + find_package without cmake install, and patches that commit to avoid the cmake_minimum_required error
  • Update vendored vector-of-bool/cmrc to 952ffdd FLAMEGPU2-visualiser#132 fixes the same issue with CMakeRC there. The commit hash here will need updating post merge, and then again for the next release.

Closes #1156

@ptheywood
Copy link
Member Author

vis pr merged, need to update hash then can merge this.

@ptheywood ptheywood merged commit 1c96a01 into master Jan 12, 2024
20 checks passed
@ptheywood ptheywood deleted the cmake-version-deprecations-fix branch January 12, 2024 11:25
@ptheywood ptheywood mentioned this pull request Feb 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robadob Robadob Awaiting requested review from Robadob

@mondus mondus Awaiting requested review from mondus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMake 3.27 Deprecation warnings (dependencies)
1 participant
@ptheywood