Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vmo 3640 dates in expr ctx #43

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

seifertk
Copy link
Collaborator

No description provided.

@seifertk seifertk requested a review from AlteaDown April 16, 2021 21:46
@seifertk
Copy link
Collaborator Author

adding 'now' for consistency with expressions documentation + DN context builder

@github-actions
Copy link

Found 10 violations:

Reporter: ESLint
Rule: eslint.rules.line-comment-position
Severity: WARN
File: src/flow-spec/IBlock.ts L175

Expected comment to be above code. (line-comment-position)

Reporter: ESLint
Rule: eslint.rules.line-comment-position
Severity: WARN
File: src/flow-spec/IBlock.ts L170

Expected comment to be above code. (line-comment-position)

Reporter: ESLint
Rule: eslint.rules.prettier/prettier
Severity: ERROR
File: src/flow-spec/IBlock.ts L162

Delete `;` (prettier/prettier)

Reporter: ESLint
Rule: eslint.rules.semi
Severity: WARN
File: src/flow-spec/IBlock.ts L162

Extra semicolon. (semi)

Reporter: ESLint
Rule: eslint.rules.prettier/prettier
Severity: ERROR
File: src/flow-spec/IBlock.ts L159

Delete `;` (prettier/prettier)

Reporter: ESLint
Rule: eslint.rules.semi
Severity: WARN
File: src/flow-spec/IBlock.ts L159

Extra semicolon. (semi)

Reporter: ESLint
Rule: eslint.rules.prettier/prettier
Severity: ERROR
File: src/flow-spec/IBlock.ts L152

Delete `;` (prettier/prettier)

Reporter: ESLint
Rule: eslint.rules.semi
Severity: WARN
File: src/flow-spec/IBlock.ts L152

Extra semicolon. (semi)

Reporter: ESLint
Rule: eslint.rules.@typescript-eslint/no-explicit-any
Severity: WARN
File: src/flow-spec/IBlock.ts L92

Unexpected any. Specify a different type. (@typescript-eslint/no-explicit-any)

Reporter: ESLint
Rule: eslint.rules.@typescript-eslint/no-explicit-any
Severity: WARN
File: src/flow-spec/IBlock.ts L89

Unexpected any. Specify a different type. (@typescript-eslint/no-explicit-any)

tomorrow.setHours(0, 0, 0, 0);

yesterday.setDate(now.getDate() - 1)
yesterday.setHours(0, 0, 0, 0);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reporter: ESLint
Rule: eslint.rules.prettier/prettier
Severity: ERROR
File: src/flow-spec/IBlock.ts L162

Delete `;` (prettier/prettier)

tomorrow.setHours(0, 0, 0, 0);

yesterday.setDate(now.getDate() - 1)
yesterday.setHours(0, 0, 0, 0);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reporter: ESLint
Rule: eslint.rules.semi
Severity: WARN
File: src/flow-spec/IBlock.ts L162

Extra semicolon. (semi)

const yesterday = new Date(now)

tomorrow.setDate(now.getDate() + 1)
tomorrow.setHours(0, 0, 0, 0);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reporter: ESLint
Rule: eslint.rules.prettier/prettier
Severity: ERROR
File: src/flow-spec/IBlock.ts L159

Delete `;` (prettier/prettier)

const yesterday = new Date(now)

tomorrow.setDate(now.getDate() + 1)
tomorrow.setHours(0, 0, 0, 0);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reporter: ESLint
Rule: eslint.rules.semi
Severity: WARN
File: src/flow-spec/IBlock.ts L159

Extra semicolon. (semi)


// today is just today's day, at midnight
const today = new Date(now)
today.setHours(0, 0, 0, 0);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reporter: ESLint
Rule: eslint.rules.prettier/prettier
Severity: ERROR
File: src/flow-spec/IBlock.ts L152

Delete `;` (prettier/prettier)


// today is just today's day, at midnight
const today = new Date(now)
today.setHours(0, 0, 0, 0);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reporter: ESLint
Rule: eslint.rules.semi
Severity: WARN
File: src/flow-spec/IBlock.ts L152

Extra semicolon. (semi)

@AlteaDown
Copy link
Collaborator

Approved, pending ESLint fixes

Copy link
Collaborator

@AlteaDown AlteaDown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved Pending ESLint fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants