Skip to content

Commit

Permalink
Update ECS config
Browse files Browse the repository at this point in the history
  • Loading branch information
Prometee committed Oct 12, 2022
1 parent 2084c03 commit 8b5883a
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 25 deletions.
28 changes: 10 additions & 18 deletions ecs.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,25 +2,17 @@

declare(strict_types=1);

use PhpCsFixer\Fixer\ClassNotation\ClassAttributesSeparationFixer;
use PhpCsFixer\Fixer\Operator\BinaryOperatorSpacesFixer;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
use PhpCsFixer\Fixer\ControlStructure\TrailingCommaInMultilineFixer;
use Symplify\EasyCodingStandard\Config\ECSConfig;

return static function (ContainerConfigurator $containerConfigurator): void {
$containerConfigurator->import(__DIR__ . '/vendor/sylius-labs/coding-standard/ecs.php');
return static function (ECSConfig $config): void {
$config->import(__DIR__ . '/vendor/sylius-labs/coding-standard/ecs.php');

$services = $containerConfigurator->services();
/**
* Was added to fix this exception:
*
* PhpCsFixer\ConfigurationException\InvalidFixerConfigurationException: [binary_operator_spaces] Invalid configuration:
* The options "align_double_arrow", "align_equals" do not exist. Defined options are: "default", "operators".
* in vendor/friendsofphp/php-cs-fixer/src/AbstractFixer.php on line 155
*/
$services->set(BinaryOperatorSpacesFixer::class);
$services = $config->services();

/**
* Miss configured fixer into sylius-labs/coding-standard v4.1.0
*/
$services->set(ClassAttributesSeparationFixer::class);
// PHP 7 compatibility
$services
->set(TrailingCommaInMultilineFixer::class)
->call('configure', [['elements' => ['arrays']]])
;
};
4 changes: 2 additions & 2 deletions src/Action/CancelAction.php
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public function execute($request): void

public function supports($request): bool
{
return $request instanceof Cancel
&& $request->getModel() instanceof ArrayAccess;
return $request instanceof Cancel &&
$request->getModel() instanceof ArrayAccess;
}
}
6 changes: 3 additions & 3 deletions src/Action/ConvertPaymentAction.php
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@ private function setEmail(ArrayObject $model, PaymentInterface $payment): void

public function supports($request): bool
{
return $request instanceof Convert
&& $request->getSource() instanceof PaymentInterface
&& $request->getTo() == 'array';
return $request instanceof Convert &&
$request->getSource() instanceof PaymentInterface &&
$request->getTo() == 'array';
}
}
4 changes: 2 additions & 2 deletions src/Action/RefundAction.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public function execute($request): void

public function supports($request): bool
{
return $request instanceof Refund
&& $request->getModel() instanceof \ArrayAccess;
return $request instanceof Refund &&
$request->getModel() instanceof \ArrayAccess;
}
}

0 comments on commit 8b5883a

Please sign in to comment.