Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Up and bugfixing #187

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Clean Up and bugfixing #187

wants to merge 8 commits into from

Conversation

FPGSchiba
Copy link
Owner

@FPGSchiba FPGSchiba commented Dec 26, 2024

Please do not merge.

Issues fixed:
⦁ Keybind Tooltip improvements
⦁ DONE Navigation Fix: Help & Settings can break > They are back buttons and should only go back to navigation or home
⦁ All Panel Dropdowns are broken (a bit too big and not styled correctly)
⦁ Some Panel Buttons are not correctly formatted (Too big text and cut off)
⦁ Adjust Pattern for FFID to include anything in Brackets (Not only uppercase things) only in matching in the playerlist. > Not the login enforcement
⦁ Effects on and off are not very clear in the settings
⦁ Lengthen Old window
⦁ Settings >Balancing instead of miscealanious
⦁ Keybinds add balancing binds to new UI under Most Used below Radio Volume
⦁ Keybinds add Swap frequencies (for swap panel) > Most Used under Intercom select
⦁ Once logged in into the new values are updated on the Old Screen
⦁ No Password with Guest > Infinite loading
⦁ Old window styling updates
⦁ Sentry Feedback form is working (Also feedback has a character limit of ~4000 Chars)
⦁ Change “Vanguard-SRS” to “VCS-SRS” in the build
⦁ Better Navigation (Back Buttons on all Pages, Give Page Settings & Support to which Page to return to)
⦁ All other unused settings under Legacy
⦁ Still issues with Login flow (Orange, but not green in one go and still going to success page) (I think its login in 2 times, or getting the callback 2 times, to log out again)
⦁ Removed Presets manager from build
⦁ R1 & IC text cut off
⦁ Channel selection dropdown -> try smaller font size?
⦁ Radio Management in keybinds
⦁ UHF effect volume doublicates
⦁ Radio panel selection menu text cut off on ultra wide
⦁ Radio modultation hiding broken - all compacted
⦁ Channel selection broken (text cut off)
⦁ Compacted saves wrong Size (For open Compacted not closed)
⦁ Swap Panel is broken, in most scaling and sizing aspects

Won't do Issues:
⦁ Make the whole App Wider and a bit Higher
⦁ Standard standby Frequencies in the awacs-radios.json (Server?)

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
25.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

* Switchable Panel Growth and Scale fixes
* Transparent Panel Growth and Scale fixes
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
44.4% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant