Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add orientation change btn for 2 vert and 2 hort #71

Merged
merged 8 commits into from
Nov 26, 2023
Merged

Conversation

gtodd876
Copy link
Collaborator

No description provided.

@FPGSchiba
Copy link
Owner

FPGSchiba commented Nov 24, 2023

Ok so it is working for the 2 Vertical and 2 Horizontal...
We do have a mechanism within the MainWindow to change the Panels. Could we use this mechanism to change the Panels so we have all Code relating to closing and opening in one place?

If you want we can talk about that at sunday 😄

One small thing: This could also lead to some issues within the CodeBase on the MainWindow.

Don't take this the wrong way, your way was good for the Information I gave you, so if you could change that, that would be awsome ;)

Dabble1SC and others added 4 commits November 24, 2023 12:12
- Added text next to the swap orientation button to identify orientation
- tightend up 2 radio horizontal panel to condense it vertically
@FPGSchiba
Copy link
Owner

This looks good to me 😄
Will you make this for all the Overlays on this branch or just the 2s right now?

@FPGSchiba FPGSchiba self-requested a review November 25, 2023 14:10
@FPGSchiba FPGSchiba added this to the Version 1.2.2 milestone Nov 25, 2023
Copy link
Owner

@FPGSchiba FPGSchiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, if you are ready you can merge those changes

@gtodd876 gtodd876 merged commit e221202 into develop Nov 26, 2023
@gtodd876 gtodd876 deleted the volts-issue48 branch November 26, 2023 14:36
Padding="0"
Text="3 Radio Panel Horizontal" />
<TextBlock x:Name="ControlText"
Width="310"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additional tabbing needed for the control text section

Copy link
Collaborator

@Dabble1SC Dabble1SC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants