Feature/58 update keybinding names #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtodd876
reviewed
Dec 4, 2023
| @@ -35,7 +35,7 @@ public InputDeviceManager InputDeviceManager | |||
| public void LoadInputSettings() | |||
| { | |||
| DeviceLabel.Content = InputName; | |||
| ModifierLabel.Content = InputName + " Modifier"; | |||
There was a problem hiding this comment.
not sure i follow what is going on in this line
There was a problem hiding this comment.
I removed the input name being included before the name modifier and put in a lot of spaces to "tab" modifier over
There was a problem hiding this comment.
Originally it said
Radio 2
Radio 2 Modifier
There was a problem hiding this comment.
is spaces the best way to achieve layout in this situation?
There was a problem hiding this comment.
It was cheap and very easy to accomplish. Additionally, it's very easy to revert back to something else without needing to change the main XAML formatting. We can always move the different cells around in XAML, but this was pretty easy and involved merely seconds to create.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.