fixed #48 , Updated docs and codeQL

FRACerqueira · Aug 7, 2023 · 2e33b94 · 2e33b94
1 parent 0104ab6
commit 2e33b94
Show file tree

Hide file tree

Showing 12 changed files with 438 additions and 100 deletions.
diff --git a/Src/Controls/Input/AutoCompleteControl.cs b/Src/Controls/Input/AutoCompleteControl.cs
@@ -447,13 +447,10 @@ public override ResultPrompt<string> TryResult(CancellationToken cancellationTok
             }
             else
             {
-                if (!skipstartComplete)
+                if (!skipstartComplete && oldinput != _inputBuffer.ToString() && oldinput != null)
                 {
-                    if (oldinput != _inputBuffer.ToString() && oldinput != null)
-                    {
-                        _autoCompleteRunning = true;
-                        _autoCompleteSendStart = true;
-                    }
+                    _autoCompleteRunning = true;
+                    _autoCompleteSendStart = true;
                 }
             }
             var clear = !_autoCompleteRunning;

diff --git a/Src/Controls/StyleSchema.cs b/Src/Controls/StyleSchema.cs
@@ -14,7 +14,7 @@ namespace PPlus.Controls
     /// </summary>
     public class StyleSchema
     {
-        private Dictionary<StyleControls, Style> _Styles;
+        private readonly Dictionary<StyleControls, Style> _Styles;
 
         internal StyleSchema()
         {

diff --git a/Src/Drivers/ConsoleDriveMemory.cs b/Src/Drivers/ConsoleDriveMemory.cs
@@ -475,7 +475,7 @@ public bool OnBuffer(TargetBuffer target, Action<CancellationToken> value, Conso
 
             try
             {
-                ForegroundColor = defaultforecolor??curforecolor;
+                ForegroundColor = defaultforecolor ?? curforecolor;
                 BackgroundColor = defaultbackcolor ?? curbackcolor;
 
                 IsControlText = true;

diff --git a/Src/Drivers/DriveExtensions.cs b/Src/Drivers/DriveExtensions.cs
@@ -23,7 +23,7 @@ public static partial class PromptPlus
     {
         private static readonly bool RunningConsoleMemory = false;
         private static readonly CultureInfo AppConsoleCulture;
-        internal static IConsoleControl _consoledrive;
+        internal static readonly IConsoleControl _consoledrive;
         private static ConfigControls _configcontrols;
         private static readonly StyleSchema _styleschema;
         private static readonly object lockrecord = new();
@@ -606,7 +606,7 @@ private static void Profile(Action<ProfileSetup> config)
 
             var param = new ProfileSetup
             {
-                IsLegacy = RunningConsoleMemory ? false: _consoledrive.IsLegacy,
+                IsLegacy = !RunningConsoleMemory && _consoledrive.IsLegacy,
                 ColorDepth = RunningConsoleMemory ? ColorSystem.TrueColor : _consoledrive.ColorDepth,
                 IsTerminal = RunningConsoleMemory || _consoledrive.IsTerminal,
                 IsUnicodeSupported = RunningConsoleMemory || _consoledrive.IsUnicodeSupported,

diff --git a/Src/Drivers/Style.cs b/Src/Drivers/Style.cs
@@ -40,9 +40,9 @@ public Style(Color foreground, Color background, Overflow overflowStrategy = Ove
         }
 
         /// <summary>
-        /// Gets a <see cref="Style"/> with the default colors and default overflow.
+        /// Gets a <see cref="Style"/> with the default colors and overflow.None
         /// </summary>
-        public static Style Default => new(PromptPlus._consoledrive.ForegroundColor, PromptPlus._consoledrive.BackgroundColor, PromptPlus._consoledrive.OverflowStrategy);
+        public static Style Default => new(Color.DefaultForecolor, Color.DefaultBackcolor, Overflow.None);
 
         /// <summary>
         /// Gets a <see cref="Style"/> with the default colors and overflow Crop.

diff --git a/docs/apis/apis.md b/docs/apis/apis.md
@@ -72,7 +72,7 @@
 
 - [ChartOrder](./pplus.controls.chartorder.md)
 
-- [Config](./pplus.controls.config.md)
+- [ConfigControls](./pplus.controls.configcontrols.md)
 
 - [EventPipe&lt;T&gt;](./pplus.controls.eventpipe-1.md)