Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spell checking pass #52

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Conversation

ividyon
Copy link
Contributor

@ividyon ividyon commented Aug 10, 2023

Thanks for all your hard work on this cool library, it makes simple commandline tools a lot more fun to make and use.

I made some spell-checking corrections. Unfortunately this is not a "trivial" PR since there were typos in various methods and variables, so it may be "breaking".

I also fixed some lingering references to SpectreConsole where they weren't intended, and some other small things of that nature.

This is not at all a comprehensive, methodical list of changes. I just fixed what I saw with my own eyes, there are likely more issues remaining, but I thought I'd push this for now.

@FRACerqueira FRACerqueira self-requested a review August 10, 2023 12:36
@FRACerqueira FRACerqueira added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 10, 2023
@FRACerqueira
Copy link
Owner

Thank you very much for your 'PR'. You did a lot of work! I will be reviewing changes that impact the core code.

A Tip: All *.md that are in the 'docs\apis' folder do not need to be revised, they are automatically generated based on the text of the comments (///), see the tool at https://github.com/FRACerqueira/ xmldoc2md .

Again I am very happy with your contribution. Hope I can get your help with you for new releases :-)

@FRACerqueira FRACerqueira linked an issue Aug 10, 2023 that may be closed by this pull request
@FRACerqueira FRACerqueira changed the base branch from main to V4.0.5 August 10, 2023 13:02
@FRACerqueira FRACerqueira added this to the V4.0.5 milestone Aug 10, 2023
Src/Controls/AddtoList/ListControl.cs Dismissed Show dismissed Hide dismissed
Src/Controls/AddtoList/ListControl.cs Dismissed Show dismissed Hide dismissed
Src/Controls/AddtoList/MaskEditListControl.cs Dismissed Show dismissed Hide dismissed
Src/Controls/AddtoList/MaskEditListControl.cs Dismissed Show dismissed Hide dismissed
Src/Controls/Input/InputControl.cs Dismissed Show dismissed Hide dismissed
Src/Controls/Input/InputControl.cs Dismissed Show dismissed Hide dismissed
Src/Controls/Input/MaskEditControl.cs Dismissed Show dismissed Hide dismissed
Src/Controls/Input/MaskEditControl.cs Dismissed Show dismissed Hide dismissed
Src/Controls/Input/MaskEditOptions.cs Dismissed Show dismissed Hide dismissed
Src/Drivers/ReadLineExtension.cs Dismissed Show dismissed Hide dismissed
@FRACerqueira FRACerqueira merged commit aff2d82 into FRACerqueira:V4.0.5 Aug 10, 2023
3 checks passed
@FRACerqueira
Copy link
Owner

@ividyon you can see and follow the result of your work in the branch:

https://github.com/FRACerqueira/PromptPlus/tree/V4.0.5

@ividyon ividyon deleted the spell-checking branch August 10, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review English language documentation
2 participants