Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Change O to 0 in TEST_simulate_retryable_error and add traceback #74

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

MartinFoka
Copy link
Collaborator

  • Corrected the incorrect assignment of the attempt count in TEST_simulate_retryable_error:

    • Changed from int(os.getenv(env_var_name, 'O')) to int(os.getenv(env_var_name, '0')).
  • Improved error handling in the execute_wrapper function:

    • Added sys.stderr.write(traceback.format_exc()) to log detailed traceback information when an exception occurs.

- Corrected the incorrect assignment of the attempt count in TEST_simulate_retryable_error:
  - Changed from `int(os.getenv(env_var_name, 'O'))` to `int(os.getenv(env_var_name, '0'))`.

- Improved error handling in the execute_wrapper function:
  - Added `sys.stderr.write(traceback.format_exc())` to log detailed traceback information when an exception occurs.
@MartinFoka MartinFoka added the bug Something isn't working label Nov 4, 2024
@MartinFoka MartinFoka marked this pull request as ready for review November 5, 2024 09:24
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

@MartinFoka MartinFoka merged commit bd2118c into main Nov 5, 2024
5 checks passed
@MartinFoka MartinFoka deleted the fix/add-traceback branch November 5, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants