Dev #51
Merged
Dev #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Give other mods a chance to cancel the teleportation based on where the player is etc. FTBTeam/FTB-Mods-Issues#841
Fix NPE when unmuting offline player Drop forge-specific event handlers for player data load/save, just use world load/save (works correctly with offline players)
Bumped version back down to 2001.1.3, shouldn't have been 2001.1.4
Allows the location of offline players to be adjusted by editing their player <uuid>.dat file directly
Teleport to where you're looking (top of focused block column) FTBTeam/FTB-Mods-Issues#741
Control your or other player's speed with a percentage boost FTBTeam/FTB-Mods-Issues#741
/anvil, /smithing, /crafting, /stonecutter FTBTeam/FTB-Mods-Issues#424
MichaelHillcox
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
No real blocking issues here, happy for it to be merged as is. Looks like some great improvements to Essentials :D
Couple of notes:
- The InventoryUtils might be best off being moved to FTB Lib in the future? Same as BlockUtils assuming the goal would be to have Lib act as one size fits all utils system.
- Kit could be a record?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A whole bunch of new commands, plus a couple of fixes