Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Properly extend the stack in CallbackInjector. #131

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Fix: Properly extend the stack in CallbackInjector. #131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/main/java/org/spongepowered/asm/mixin/injection/callback/CallbackInjector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,10 +212,7 @@ private class Callback extends InsnList {
this.invoke = target.extendStack();
this.ctor = target.extendStack();

this.invoke.add(target.arguments.length);
if (this.canCaptureLocals) {
this.invoke.add(this.localTypes.length - this.frameSize);
}
this.invoke.add().add(handlerArgs);

//If the handler doesn't captureArgs, the CallbackInfo(Returnable) will be the first LVT slot, otherwise it will be at the target's frameSize
int callbackInfoSlot = handlerArgs.length == 1 ? Bytecode.isStatic(handler) ? 0 : 1 : frameSize;
Expand Down
Loading