Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Modlauncher bytecode provider class parser flags #137

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

Su5eD
Copy link

@Su5eD Su5eD commented Apr 16, 2024

Changes the flags used to read ClassNodes in Mixin's modlauncher bytecode provider class, MixinLaunchPluginLegacy, to use 0 instead of ClassReader.EXPAND_FRAMES. This is to ensure the correctness of local variable analysis, as well as to achieve parity with Fabric's flag usage (which is currently the opposite of modlauncher's settings).

classReader.accept(classNode, ClassReader.EXPAND_FRAMES);

For a complete description of the issue, please see neoforged/NeoForge#768.

Copy link
Member

@modmuss50 modmuss50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, I have no way to test this change, so might be best to get another neoforge dev to approve as well?

@modmuss50 modmuss50 merged commit e779303 into FabricMC:main Apr 16, 2024
4 checks passed
LlamaLad7 added a commit that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants