Add the ability to modify server launch command #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This server installer UI has been depercated for years and should honestly be removed, Im not sure its worth developing it further. |
|
You mean it should be replaced? |
|
It was replaced years ago by the executable server jar from https://fabricmc.net/use/server/ There is a big warnings on this screen pointing users towards the website. There should be little to no reason to use the installer for the server anymore. |
It's more of a fix, and extending installer functionality is a side-effect. I fell for this issue myself, when modifying that text box and thinking that I've given more memory to the server. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's possible to modify launch command text field in server post-installation dialog, but it doesn't actually affect generated scripts. It's misleading (it's an issue) and I think that making it actually apply to launch scripts instead of making it immutable is a better solution.