more javadoc and fixed biomes in temperature tag

FabricMC · Oct 14, 2024 · 5236d2d · 5236d2d
1 parent 611b66e
commit 5236d2d
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 5 deletions.
diff --git a/...en/java/net/fabricmc/fabric/impl/tag/convention/datagen/generators/BiomeTagGenerator.java b/...en/java/net/fabricmc/fabric/impl/tag/convention/datagen/generators/BiomeTagGenerator.java
@@ -189,6 +189,7 @@ private void generateClimateAndVegetationTags() {
 				.add(BiomeKeys.CHERRY_GROVE)
 				.add(BiomeKeys.MEADOW)
 				.add(BiomeKeys.SWAMP)
+				.add(BiomeKeys.MANGROVE_SWAMP)
 				.add(BiomeKeys.BEACH)
 				.add(BiomeKeys.OCEAN)
 				.add(BiomeKeys.DEEP_OCEAN);
@@ -200,7 +201,6 @@ private void generateClimateAndVegetationTags() {
 				.addTag(ConventionalBiomeTags.IS_TEMPERATE_END);
 
 		getOrCreateTagBuilder(ConventionalBiomeTags.IS_HOT_OVERWORLD)
-				.add(BiomeKeys.MANGROVE_SWAMP)
 				.add(BiomeKeys.JUNGLE)
 				.add(BiomeKeys.BAMBOO_JUNGLE)
 				.add(BiomeKeys.SPARSE_JUNGLE)
@@ -212,6 +212,7 @@ private void generateClimateAndVegetationTags() {
 				.add(BiomeKeys.SAVANNA_PLATEAU)
 				.add(BiomeKeys.WINDSWEPT_SAVANNA)
 				.add(BiomeKeys.STONY_PEAKS)
+				.add(BiomeKeys.MUSHROOM_FIELDS)
 				.add(BiomeKeys.WARM_OCEAN);
 		getOrCreateTagBuilder(ConventionalBiomeTags.IS_HOT_NETHER)
 				.add(BiomeKeys.NETHER_WASTES)

diff --git a/...ags-v2/src/main/java/net/fabricmc/fabric/api/tag/convention/v2/ConventionalBiomeTags.java b/...ags-v2/src/main/java/net/fabricmc/fabric/api/tag/convention/v2/ConventionalBiomeTags.java
@@ -55,16 +55,25 @@ private ConventionalBiomeTags() {
 	 */
 	public static final TagKey<Biome> IS_OVERWORLD = register("is_overworld");
 
+	/**
+	 * Biomes that are between above 0.8 temperature. (Excluding 0.8)
+	 */
 	public static final TagKey<Biome> IS_HOT = register("is_hot");
 	public static final TagKey<Biome> IS_HOT_OVERWORLD = register("is_hot/overworld");
 	public static final TagKey<Biome> IS_HOT_NETHER = register("is_hot/nether");
 	public static final TagKey<Biome> IS_HOT_END = register("is_hot/end");
 
+	/**
+	 * Biomes that are between 0.5 and 0.8 temperature range. (Including 0.5 and 0.8)
+	 */
 	public static final TagKey<Biome> IS_TEMPERATE = register("is_temperate");
 	public static final TagKey<Biome> IS_TEMPERATE_OVERWORLD = register("is_temperate/overworld");
 	public static final TagKey<Biome> IS_TEMPERATE_NETHER = register("is_temperate/nether");
 	public static final TagKey<Biome> IS_TEMPERATE_END = register("is_temperate/end");
 
+	/**
+	 * Biomes that are between below 0.5 temperature. (Excluding 0.5)
+	 */
 	public static final TagKey<Biome> IS_COLD = register("is_cold");
 	public static final TagKey<Biome> IS_COLD_OVERWORLD = register("is_cold/overworld");
 	public static final TagKey<Biome> IS_COLD_NETHER = register("is_cold/nether");

diff --git a/...ags-v2/src/main/java/net/fabricmc/fabric/api/tag/convention/v2/ConventionalBlockTags.java b/...ags-v2/src/main/java/net/fabricmc/fabric/api/tag/convention/v2/ConventionalBlockTags.java
@@ -209,12 +209,12 @@ private ConventionalBlockTags() {
 	public static final TagKey<Block> ORE_BEARING_GROUND_STONE = register("ore_bearing_ground/stone");
 	/**
 	 * Ores which on average result in more than one resource worth of materials ignoring fortune and other modifiers.
-	 * (example, Redstone Ore)
+	 * (example, Copper Ore)
 	 */
 	public static final TagKey<Block> ORE_RATES_DENSE = register("ore_rates/dense");
 	/**
 	 * Ores which on average result in one resource worth of materials ignoring fortune and other modifiers.
-	 * (Example, Coal Ore)
+	 * (Example, Iron Ore)
 	 */
 	public static final TagKey<Block> ORE_RATES_SINGULAR = register("ore_rates/singular");
 	/**

diff --git a/...tags-v2/src/main/java/net/fabricmc/fabric/api/tag/convention/v2/ConventionalItemTags.java b/...tags-v2/src/main/java/net/fabricmc/fabric/api/tag/convention/v2/ConventionalItemTags.java
@@ -433,12 +433,12 @@ private ConventionalItemTags() {
 	public static final TagKey<Item> ORE_BEARING_GROUND_STONE = register("ore_bearing_ground/stone");
 	/**
 	 * Ores which on average result in more than one resource worth of materials ignoring fortune and other modifiers.
-	 * (example, Redstone Ore)
+	 * (example, Copper Ore)
 	 */
 	public static final TagKey<Item> ORE_RATES_DENSE = register("ore_rates/dense");
 	/**
 	 * Ores which on average result in one resource worth of materials ignoring fortune and other modifiers.
-	 * (Example, Coal Ore)
+	 * (Example, Iron Ore)
 	 */
 	public static final TagKey<Item> ORE_RATES_SINGULAR = register("ore_rates/singular");
 	/**