Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Random mismatch between vanilla and FRAPI baked models (weighted and multipart) #3282

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Fix Random mismatch between vanilla and FRAPI baked models (weighted and multipart) #3282

merged 2 commits into from
Sep 18, 2023

Conversation

Technici4n
Copy link
Member

Fixes #3278.

@Technici4n Technici4n requested review from PepperCode1 and a team August 27, 2023 10:56
modmuss50
modmuss50 approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@modmuss50 modmuss50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, awesome test 👍

@Technici4n Technici4n added the merge me please Pull requests that are ready to merge label Sep 4, 2023
@modmuss50 modmuss50 merged commit ecfd5a8 into FabricMC:1.20.1 Sep 18, 2023
5 checks passed
modmuss50 pushed a commit that referenced this pull request Sep 18, 2023
@Technici4n @modmuss50
Fix Random mismatch between vanilla and FRAPI baked models (weighted …
bbfadae 
…and multipart) (#3282)

* Fix Random mismatch between vanilla and FRAPI baked models (weighted and multipart)

* Review comments

(cherry picked from commit ecfd5a8)
cocona20xx pushed a commit to cocona20xx/quilted-fabric-api that referenced this pull request Sep 24, 2023
@Technici4n @cocona20xx
Fix Random mismatch between vanilla and FRAPI baked models (weighted …
5dd2ab9 
…and multipart) (FabricMC#3282)

* Fix Random mismatch between vanilla and FRAPI baked models (weighted and multipart)

* Review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@modmuss50 modmuss50 modmuss50 approved these changes

@PepperCode1 PepperCode1 PepperCode1 approved these changes

Assignees
No one assigned
Labels
merge me please Pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chorus Plant is not rendered correctly, it seems to be rendered with a rotation.
3 participants
@Technici4n @modmuss50 @PepperCode1