FRAPI improvements: context getters, full removal of fallback consumers, small enhancements #3287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cull check and item transformation mode getter to FRAPI
New methods in
RenderContext
:isFaceCulled
to perform a cull check that can be optimized and cached by the renderer.hasTransform
, self-explanatory. Must be checked before usingisFaceCulled
to skip some geometry.itemTransformationMode
to get the current item transformation mode in item contexts.Terminally deprecate
fallbackConsumer
andbakedModelConsumer
The primary goal of this change is to make renderers not need to implement these fallback consumers themselves. However, their design relies on hidden context state that cannot be queried via the API. It is thus impossible to implement a fallback layer for them, and they must be deprecated, with plans for removal in
1.20.2(EDIT: too late for that) in a follow-up PR.Note that
BakedQuadFallback.emitBlockQuads
uses the newly introducedisFaceCulled
andhasTransform
methods to shortcut some geometric analysis.I also removed the "vanilla quad handler" from Indigo.
Fix uvs in octagonal column test mod
Fix the uvs in the octagonal column test mod by:
spriteBake
for the axis-aligned quads;