Use ConcurrentHashMap inside RegistryAttributeImpl
#3970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apple502j
added
registry-sync
modmuss50
approved these changes
Jul 25, 2024
modmuss50
pushed a commit
that referenced
this pull request
Jul 29, 2024
(cherry picked from commit a5d6675)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3969
Needs backport to whatever version is supported
A
static finalmap, keyed byRegistryKeyof a registry, was being modified in the worker thread, which sometimes caused CME. The registry itself does not suffer from this problem, as a registry cannot be modified by more than one thread due to freezing. However, two registries could be created in two threads; thus requiring this change.