Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename pauseWhenMobIdle to skipMobIdleCheck #3068

Open
wants to merge 1 commit into
base: 1.17.1
Choose a base branch
from

Conversation

SFort
Copy link

@SFort SFort commented Mar 28, 2022

The variable is used twice

if (!pauseWhenMobIdle) {
    //stops when idle
} else if {
    //other checks which get skipped
}
if (pauseWhenMobIdle || mob.canSee(player)){
    //Mob moves twords player 
}

most entities appear to have it set to false with the Ravager having it set to true

due to the second use i don't think skipMobIdleCheck is entierly accurate but i also can't think of something that makes sense for both

@liach liach added the release A PR that targets a release version of Minecraft label Mar 28, 2022
@modmuss50
Copy link
Member

Can we make sure this change happens in the snapshot branch first, then it can be backported as required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release A PR that targets a release version of Minecraft
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants