Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jdocs for ArmorMaterial class #3323

Merged
merged 7 commits into from
Sep 1, 2023
Merged

Add jdocs for ArmorMaterial class #3323

merged 7 commits into from
Sep 1, 2023

Conversation

Draylar
Copy link
Contributor

@Draylar Draylar commented Oct 19, 2022

Going to cover ToolMaterial tomorrow. Thanks in advance for your feedback & critique!

@apple502j
Copy link
Contributor

apple502j commented Oct 19, 2022 •
edited
Loading

@Draylar Just FYI, regular snapshot cycle starts today, so could you wait until the snapshot release and work on javadoc on snapshot branch (assuming, ofc, tool material still exists)?

Also, if possible could you join Fabric official Discord? see https://fabricmc.net/discuss/

@haykam821 haykam821 added release A PR that targets a release version of Minecraft javadoc A PR that adds or refactors javadoc. labels Oct 19, 2022
@Draylar Draylar changed the base branch from 1.19.2 to 22w42a October 20, 2022 07:53
@YanisBft YanisBft added snapshot A PR that targets a snapshot version of Minecraft and removed release A PR that targets a release version of Minecraft labels Oct 20, 2022
YanisBft
YanisBft previously approved these changes Oct 20, 2022
View reviewed changes
@YanisBft YanisBft requested a review from enbrain October 21, 2022 09:11
@YanisBft YanisBft added the update-base Add this label to a pull request to automatically change the target branch to the default branch. label Nov 2, 2022
@github-actions github-actions bot changed the base branch from 22w42a to 22w43a November 2, 2022 10:54
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

🚀 Target branch has been updated to 22w43a

@modmuss50 modmuss50 removed the update-base Add this label to a pull request to automatically change the target branch to the default branch. label Nov 21, 2022
@Juuxel Juuxel added the update-base Add this label to a pull request to automatically change the target branch to the default branch. label Dec 11, 2022
@github-actions github-actions bot changed the base branch from 22w43a to 1.19.3 December 11, 2022 11:23
@github-actions
Copy link
Contributor

🚀 Target branch has been updated to 1.19.3

@Juuxel Juuxel added release A PR that targets a release version of Minecraft and removed snapshot A PR that targets a snapshot version of Minecraft update-base Add this label to a pull request to automatically change the target branch to the default branch. labels Dec 11, 2022
@Juuxel Juuxel added the update-base Add this label to a pull request to automatically change the target branch to the default branch. label Jul 20, 2023
@github-actions
Copy link
Contributor

🚀 Target branch has been updated to 1.20.1

@github-actions github-actions bot changed the base branch from 1.19.3 to 1.20.1 July 20, 2023 18:15
@github-actions github-actions bot dismissed YanisBft’s stale review July 20, 2023 18:15

The base branch was changed.

@github-actions
Copy link
Contributor

🚨 Please fix merge conflicts before this can be merged

@github-actions github-actions bot added outdated A PR that targets an outdated branch. and removed update-base Add this label to a pull request to automatically change the target branch to the default branch. labels Jul 20, 2023
@YanisBft YanisBft changed the base branch from 1.20.1 to 23w35a September 1, 2023 04:12
@YanisBft YanisBft requested a review from a team as a code owner September 1, 2023 04:28
@YanisBft YanisBft added snapshot A PR that targets a snapshot version of Minecraft and removed outdated A PR that targets an outdated branch. release A PR that targets a release version of Minecraft labels Sep 1, 2023
@apple502j apple502j merged commit aec943a into FabricMC:23w35a Sep 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Juuxel Juuxel Juuxel left review comments

@YanisBft YanisBft YanisBft approved these changes

@apple502j apple502j apple502j approved these changes

@enbrain enbrain enbrain approved these changes

Assignees
No one assigned
Labels
javadoc A PR that adds or refactors javadoc. snapshot A PR that targets a snapshot version of Minecraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Draylar @apple502j @Juuxel @YanisBft @enbrain @modmuss50 @haykam821