Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforcing sidedness for client package #3601

Draft
wants to merge 13 commits into
base: 1.20.1
Choose a base branch
from

Conversation

natanjunges
Copy link

Implements changes proposed in #3196, starting by the least impactful ones.

@Juuxel Juuxel added refactor A PR that renames existing names. release A PR that targets a release version of Minecraft labels Jul 2, 2023
@natanjunges natanjunges marked this pull request as ready for review July 2, 2023 22:51
@modmuss50 modmuss50 added the impactful A change that is likely to affect some mods. Will require more reviews. label Jul 3, 2023
@natanjunges natanjunges marked this pull request as draft July 3, 2023 11:53
@modmuss50
Copy link
Member

This looks like a good start likely should go into the next badly breaking Minecraft version.

Once this is ready we should also look into adding some tools to validate these packages. I can possibly look into moving yarn to use a split jar instead of a merged jar, should make this easier.

@natanjunges
Copy link
Author

natanjunges commented Jul 3, 2023

Where should I move the following classes to:

  • net.minecraft.client.option.ChatVisibility should go under net.minecraft.network or net.minecraft.network.message?
  • net.minecraft.client.render.BlockBreakingInfo should really go under net.minecraft.entity.player, or is there any other place where it fits better?
  • net.minecraft.client.util.NetworkUtils should go under net.minecraft.utilor net.minecraft.network?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impactful A change that is likely to affect some mods. Will require more reviews. refactor A PR that renames existing names. release A PR that targets a release version of Minecraft
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants