-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforcing sidedness for client package #3601
Draft
natanjunges
wants to merge
13
commits into
FabricMC:1.20.1
Choose a base branch
from
natanjunges:1.20.1
base: 1.20.1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juuxel
added
refactor
A PR that renames existing names.
release
A PR that targets a release version of Minecraft
labels
Jul 2, 2023
Juuxel
reviewed
Jul 2, 2023
filament/src/test/resources/projects/sharedData/yarn-mappings-v2.tiny
Outdated
Show resolved
Hide resolved
modmuss50
added
the
impactful
A change that is likely to affect some mods. Will require more reviews.
label
Jul 3, 2023
This looks like a good start likely should go into the next badly breaking Minecraft version. Once this is ready we should also look into adding some tools to validate these packages. I can possibly look into moving yarn to use a split jar instead of a merged jar, should make this easier. |
Where should I move the following classes to:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements changes proposed in #3196, starting by the least impactful ones.