Update fabrik-element-calc-form.php #2227
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calc element had been written to use a class that had been defined as a static "input-medium" size and it would ignore the columns (width) param. This update translates cols into bootstrap class definition to allow variable width based on cols. Also cleaned up the code to use heredoc for the HTML.
Cons: Previous, cols were ignored in bootstrap templates. Now, it will have an effect. A dev might need to adjust their cols param to suit and it's not obvious or documented that the translation points are 15, 40, and 60. If this commit is accepted, notify me and I'll update the wiki - [email protected]