-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend Speedup #2183
base: master
Are you sure you want to change the base?
Frontend Speedup #2183
Conversation
This looks good, if it works in Awesomium. There are a few places you could reduce jQuery reliance further while still working in Awesomium if you wanted. Some examples on loading.html replacing jQuery with vanilla javascript
|
Awesomium is working. Yes, your suggestions are good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked out these changes briefly in both x86-64 and Main and I didn't experience any regressions. Everything seems to work without issue. I'd endorse merging.
Only thing I wonder is if we even still need jquery-color.js and jquery-ui.js, and if so, could they be replaced with lightweight standard jquery use or vanilla javascript. But that's probably worth doing as a separate pull request.
Performance Boost for Frontend
defer
for images that load only under specific conditions.DOMContentLoaded
, improving rendering speed and response time.The jQuery update was tested, and no issues were detected. All existing functionality remains fully operational, and the overall performance has slightly improved with the new version.