Fix FairRoot::FastSim RPATH resolution on Linux #1524
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store RPATH information in FairFastSim library instead of RUNPATH information. On many Linux systems only primary library dependencies are properly resolved when only RUNPATH information is available. Secondary indirect dependencies are not found when linking an excutable against the FairFastSim library. fixes FairRootGroup#1523
dennisklein
reviewed
Apr 19, 2024
There was a problem hiding this comment.
Based on your research and findings in this issue - thx! ❤️ - we realized that we should rather set LD_LIBRARY_PATH (as workaround) as we do for the root macro based tests. See #1525
Fixing this issue by falling back to RPATH is too invasive and only works by conincidence with legacy FairSoft because we install all transitive dependencies into the same directory.
| # found. | ||
| # Send patches to upstrean such that that geant4, geant4_vmc and vgm | ||
| # correctly build libraries with RPATH information. | ||
| if(CMAKE_SYSTEM_NAME STREQUAL "Linux") |
There was a problem hiding this comment.
This condition is too general, as it is not needed on some systems.
Comment on lines
+70
to
+71
| # Send patches to upstrean such that that geant4, geant4_vmc and vgm | ||
| # correctly build libraries with RPATH information. |
There was a problem hiding this comment.
👍 Opened FairRootGroup/FairSoft#535 to track this effort!
|
Close id favour of #1524. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1523
Checklist: