feat: add postgres support + migrations #628
Conversation
Merge 'origin/develop' into main
Merge develop into main
Merge 'develop' into main
Merge develop into main
…ed ssl for postgres config Fallenbagel#186
|
Whats the difference between this and #421? |
This PR contains all the changes in #421 plus changes from @ralgar that are also mentioned in that PR. Additionally, this PR contains the migration script required to get postgres running, documentation on how to configure postgres, and improved ssl configuration options |
…nto v1.7.0/postgresql # Conflicts: # README.md # yarn.lock
|
I know that this is not the current priority to get in, but do we have even a hand wave idea of potentially how long it may be? I can continue to use the preview container but I am eagerly awaiting this not being a preview feature :) |
|
Is there a timeframe to merge this? Since running in kubernetes this is a deal breaker for now |
|
Chiming in to say, I migrated from Overseerr to Jellyseerr for this. I'm also running in Kubernetes, and I'm trying to move everything I can to postgres. |
|
I’d like to add this to my docker stack as well. Quite keen to have it working with Postgres |
github-actions
bot
removed
the
merge conflict
|
|
|
@nodadyoushutup @joaopedrocg27 I expect this to be merged in approximately 1 month. I can't promise anything though 😅 |
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
|
@dr-carrot any update on this? |
There was a problem hiding this comment.
I think this should be in the docs/extending-jellyseerr folder instead of docs/getting-started because it does not describe a setup process, but how to configure an additional tool.
| CONFIG_DIRECTORY="config" # The path to the config directory where the db file is stored | ||
| DB_LOG_QUERIES="false" # Whether to log the DB queries for debugging |
There was a problem hiding this comment.
Maybe write explicitly the default options?
| DB_TYPE="postgres" # Which DB engine to use, either "sqlite" or "postgres". The default is "sqlite". To use postgres, this needs to be set to "postgres" | ||
| DB_HOST="postgres" # The host (url) of the database | ||
| DB_PORT="5432" # The port to connect to | ||
| DB_USER="jellyseerr" # Username used to connect to the database | ||
| DB_PASS="postgres" # Password of the user used to connect to the database | ||
| DB_NAME="jellyseerr" # The name of the database to connect to | ||
| DB_LOG_QUERIES="false" # Whether to log the DB queries for debugging | ||
| DB_USE_SSL="false" # Whether to enable ssl for database connection | ||
|
|
||
| # The following options can be used to further configure ssl: | ||
| DB_SSL_REJECT_UNAUTHORIZED="true" # Whether to reject ssl connections with unverifiable certificates i.e. self-signed certificates without providing the below settings | ||
| DB_SSL_CA= # The CA certificate to verify the connection, provided as a string | ||
| DB_SSL_CA_FILE= # The path to a CA certificate to verify the connection | ||
| DB_SSL_KEY= # The private key for the connection in PEM format, provided as a string | ||
| DB_SSL_KEY_FILE= # Path to the private key for the connection in PEM format | ||
| DB_SSL_CERT= # Certificate chain in pem format for the private key, provided as a string | ||
| DB_SSL_CERT_FILE= # Path to certificate chain in pem format for the private key |
There was a problem hiding this comment.
Same here. Write explicitly what is the default value, and if it mandatory (because for instance the default value of DB_USER is not jellyseerr).
There was a problem hiding this comment.
I made some changes to hopefully make it a little more clear
|
Could you please also take a look at the cypress tests? Looks like the PR is breaking them. Could you find out why and fix your code or the tests accordingly? |
| public lastSeasonChange: Date; | ||
|
|
||
| @Column({ type: 'datetime', nullable: true }) | ||
| @DbAwareColumn({ type: 'datetime', default: () => 'now()' }) |
There was a problem hiding this comment.
Genuine question: why is this DbAwareColumn only necessary here?
Description
Screenshot (if UI-related)
To-Dos
yarn buildyarn i18n:extractIssues Fixed or Closed
TODO:
drcarrot/jellyseerr-postgres:latestSwitch date column types to remove timezoneIt is generally recommended to usetimestamp with timezoneakatimestampz