Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updating scrollview reseting scroll position #223

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: updating scrollview reseting scroll position #223

wants to merge 3 commits into from
+31 −38

Commits on Oct 7, 2014

  1. fix: updating scrollview reseting scroll position 

    When adding, removing and updating items inside a scrollview it was rebuilding the node from scratch causing it to break the scroll experience by reseting the position to 0.

This way the ViewSequence is reused as according to best practices and the user experience becomes as expected.

I also took the liberty to make it more performant when removing items.
    @JonnyBGod
    JonnyBGod committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    56982d8 View commit details
    Browse the repository at this point in the history

  2. test: should unregister children when their scopes are destroyed

    @JonnyBGod
    JonnyBGod committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    07f38a5 View commit details
    Browse the repository at this point in the history

  3. fix: test complience

    @JonnyBGod
    JonnyBGod committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    cc710a9 View commit details
    Browse the repository at this point in the history