-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rodentia Species #208
Rodentia Species #208
Conversation
RSI Diff Bot; head commit 7f354a5 merging into a9de443 Resources/Textures/DeltaV/Effects/speech.rsi
Resources/Textures/DeltaV/Mobs/Customization/Rodentia/body_markings.rsi
Resources/Textures/DeltaV/Mobs/Customization/Rodentia/cheek_markings.rsi
Resources/Textures/DeltaV/Mobs/Customization/Rodentia/ear_markings.rsi
Resources/Textures/DeltaV/Mobs/Customization/Rodentia/head_markings.rsi
Resources/Textures/DeltaV/Mobs/Customization/Rodentia/snout_markings.rsi
Resources/Textures/DeltaV/Mobs/Customization/Rodentia/tail_markings.rsi
Resources/Textures/DeltaV/Mobs/Species/Rodentia/parts.rsi
|
Gave a quick look, not a full review yet but wow, this specie kinda add nothing C#, KINDA. Its just all .yml; tho the thing that worries me is the hide under table as our laying down system may conflict with it/do the same. @Mnemotechnician Can you tell me regarding the layingdown system about laying down on tables? you hide under it right? |
You'll actually need to delete the Rodentia's system for crawling underneath tables, because on EE everyone can do that. So it's not a feature unique to Rodentia. |
Thats what i guessed. |
Content.Shared/DeltaV/Abilities/SharedCrawlUnderObjectsSystem.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following Traits will need to have them blacklisted:
TrapAvoider
Small
Claws
Some Components and missing and make sure compleatly you do not override others species and make you also to add all the needed component on the specie.
Content.Shared/DeltaV/Abilities/AlwaysTriggerMousetrapComponent.cs
Outdated
Show resolved
Hide resolved
Content.Shared/DeltaV/Abilities/SharedCrawlUnderObjectsSystem.cs
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Mobs/Customization/Markings/gauze.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: VMSolidus <[email protected]>
Co-authored-by: VMSolidus <[email protected]>
Co-authored-by: FoxxoTrystan <[email protected]>
Co-authored-by: FoxxoTrystan <[email protected]>
requesting review again for update on what can be done further |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once more the following traits need to be restricted.
TrapAvoider
Small
Claws
Co-authored-by: FoxxoTrystan <[email protected]>
… into Nikko-Species
Description
This PR adds the Rodentia species from DeltaV into Floof.
Changelog
🆑