Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rodentia Species #208

Merged
merged 15 commits into from
Sep 27, 2024
Merged

Rodentia Species #208

merged 15 commits into from
Sep 27, 2024

Conversation

Memeji
Copy link
Collaborator

@Memeji Memeji commented Sep 25, 2024

Description

This PR adds the Rodentia species from DeltaV into Floof.


Changelog

🆑

  • add: The Rodentia species can now be played in Floof.

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Documentation Changes any xml or md files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files Status: Needs Review Someone please review this labels Sep 25, 2024
@Floof-Station-Bot Floof-Station-Bot changed the title Nikko species Nikko Species Sep 25, 2024
Copy link
Contributor

github-actions bot commented Sep 25, 2024

RSI Diff Bot; head commit 7f354a5 merging into a9de443
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Effects/creampie.rsi

State Old New Status
creampie_rodentia Added

Resources/Textures/DeltaV/Effects/speech.rsi

State Old New Status
rodentia0 Added
rodentia1 Added
rodentia2 Added

Resources/Textures/DeltaV/Mobs/Customization/Rodentia/body_markings.rsi

State Old New Status
countershade Added
countershade_f Added
countershade_lleg Added
countershade_rleg Added
fawn Added
hooded Added
hooded_f Added

Resources/Textures/DeltaV/Mobs/Customization/Rodentia/cheek_markings.rsi

State Old New Status
cheeks Added
cheeks_overlay Added
fluff Added
fluff_alt Added
fluff_alt_overlay Added
fluff_overlay Added
whiskers Added

Resources/Textures/DeltaV/Mobs/Customization/Rodentia/ear_markings.rsi

State Old New Status
bat Added
bat_large Added
hamster Added
hamster_overlay Added
long Added
long_overlay Added
mouse Added
mouse_large Added
mouse_large_overlay Added
mouse_overlay Added
none Added
pointy Added
rabbit Added
rabbit_overlay Added
small Added

Resources/Textures/DeltaV/Mobs/Customization/Rodentia/head_markings.rsi

State Old New Status
blaze Added
round Added

Resources/Textures/DeltaV/Mobs/Customization/Rodentia/snout_markings.rsi

State Old New Status
bat Added
bat_nose Added
bat_overlay Added
flat Added
flat_nose Added
flat_overlay Added
round Added
round_nose Added
round_overlay Added

Resources/Textures/DeltaV/Mobs/Customization/Rodentia/tail_markings.rsi

State Old New Status
beaver Added
hamster Added
long Added
long_overlay Added
long_tip Added
mouse Added
rabbit Added
rabbit_overlay Added
short Added
squirrel Added
squirrel_overlay Added

Resources/Textures/DeltaV/Mobs/Species/Rodentia/parts.rsi

State Old New Status
full Added
head_f Added
head_m Added
l_arm Added
l_foot Added
l_hand Added
l_leg Added
r_arm Added
r_foot Added
r_hand Added
r_leg Added
torso_f Added
torso_m Added

Edit: diff updated after 7f354a5

@Memeji Memeji changed the title Nikko Species Rodentia Species Sep 25, 2024
@FoxxoTrystan FoxxoTrystan added the Priority: 1-High Needs to be resolved as soon as possible label Sep 25, 2024
@FoxxoTrystan
Copy link
Collaborator

Gave a quick look, not a full review yet but wow, this specie kinda add nothing C#, KINDA.

Its just all .yml; tho the thing that worries me is the hide under table as our laying down system may conflict with it/do the same.
Let me just get a tiny of test and details and see about it.

@Mnemotechnician Can you tell me regarding the layingdown system about laying down on tables? you hide under it right?

@VMSolidus
Copy link
Contributor

Gave a quick look, not a full review yet but wow, this specie kinda add nothing C#, KINDA.

Its just all .yml; tho the thing that worries me is the hide under table as our laying down system may conflict with it/do the same. Let me just get a tiny of test and details and see about it.

@Mnemotechnician Can you tell me regarding the layingdown system about laying down on tables? you hide under it right?

You'll actually need to delete the Rodentia's system for crawling underneath tables, because on EE everyone can do that. So it's not a feature unique to Rodentia.

@FoxxoTrystan
Copy link
Collaborator

Gave a quick look, not a full review yet but wow, this specie kinda add nothing C#, KINDA.
Its just all .yml; tho the thing that worries me is the hide under table as our laying down system may conflict with it/do the same. Let me just get a tiny of test and details and see about it.
@Mnemotechnician Can you tell me regarding the layingdown system about laying down on tables? you hide under it right?

You'll actually need to delete the Rodentia's system for crawling underneath tables, because on EE everyone can do that. So it's not a feature unique to Rodentia.

Thats what i guessed.

Copy link
Collaborator

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following Traits will need to have them blacklisted:

TrapAvoider
Small
Claws

Some Components and missing and make sure compleatly you do not override others species and make you also to add all the needed component on the specie.

Content.Client/DeltaV/Abilities/CrawlUnderObjectsSystem.cs Outdated Show resolved Hide resolved
Content.Server/DeltaV/Abilities/CrawlUnderObjectsSystem.cs Outdated Show resolved Hide resolved
Resources/Prototypes/DeltaV/Species/rodentia.yml Outdated Show resolved Hide resolved
@FoxxoTrystan FoxxoTrystan added Status: Awaiting Changes Do not merge due to requested changes and removed Status: Needs Review Someone please review this labels Sep 25, 2024
@github-actions github-actions bot added Status: Needs Review Someone please review this and removed Status: Awaiting Changes Do not merge due to requested changes labels Sep 26, 2024
@Memeji
Copy link
Collaborator Author

Memeji commented Sep 26, 2024

requesting review again for update on what can be done further

Copy link
Collaborator

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once more the following traits need to be restricted.

TrapAvoider
Small
Claws

@FoxxoTrystan FoxxoTrystan added Status: Awaiting Changes Do not merge due to requested changes and removed Status: Needs Review Someone please review this labels Sep 27, 2024
@Memeji Memeji requested a review from FoxxoTrystan September 27, 2024 21:45
@github-actions github-actions bot added Status: Needs Review Someone please review this and removed Status: Awaiting Changes Do not merge due to requested changes labels Sep 27, 2024
@FoxxoTrystan FoxxoTrystan merged commit 003066d into Fansana:master Sep 27, 2024
13 checks passed
Floof-Station-Bot added a commit that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Documentation Changes any xml or md files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files Priority: 1-High Needs to be resolved as soon as possible Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants