Shadowkin #241
Closed
Shadowkin #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Description Grrrr, I may have forgotten to remove it as a part of #733. Signed-off-by: Mnemotechnican <[email protected]>
# Description Simple-Station/Einstein-Engines#794 apparently silently deprecated the Backpack Preferences button. Selecting a backpack preference no longer actually does anything, and instead your backpack comes from your Loadout. This would have been fine if we were warned about this, but because nobody merged upstream for 2 weeks after the release of PR794, this issue went unreported. Well now the solution is going to require adding every backpack in the entire game to a new Backpacks tab. I've started this PR, but because it's really late and I have Calculus classes in the morning, I won't be able to finish it tonight. So I'm enlisting the help of a few other people I know to PR to this PR to help get the backpacks in. After we have backpacks in the loadout tab, and after Wizmerge, I'll probably do a separate PR to actually remove the now useless Backpack selection button. This is probably for the better long term. Since this technically means Backpack slots are no longer hardcoded to "Backpack/Duffelbag/Satchel", and now the back slot is freeeeee to be used for anything. <details><summary><h1>Media</h1></summary> <p>  </p> </details> # Changelog :cl: - add: Backpacks, Duffelbags, and Satchels have been added to loadouts. - remove: The button for "Backpack Preference" has been removed. Backpacks selection is now done via Loadouts. - remove: The button for "Suit/Skirt Preference" has also been removed. Suit selection is done via Loadouts.
# Description This fixes a bug with IPCs where the button to reboot them wasn't appearing. <details><summary><h1>Media</h1></summary> <p>  </p> </details> # Changelog :cl: - fix: Fixed a bug where the button to reboot IPCs wasn't appearing.
# Description Apparently _mobThreshold.TryGetThresholdForState() fucking crashes if you hand it a mob that doesn't have a MobStateComponent, even though it optionally accepts no MobStateComponent at all as one of its inputs. Easy solution for this is to just pre-emptively TryComp for the MobStateComponent and then pass it in explicitly, but I also hate this because TryGetThresholdForState shouldn't be crashing if you hand it a mob without a MobStateComponent... I hate Resolve() so much for this behavior. # Changelog :cl: - fix: Fix a crash related to Luminous Entities.
# Description This fixes a bug whereby smoking a cigarette spams your screen with the funny "I feel as if I have been standing my entire life and I just sat down" message. Now moodlet popups only play once when the moodlet is obtained, rather than being constantly spammed. I have tested this ingame to verify that it works correctly. # Changelog :cl: - fix: Smoking cigarettes or drinking loto oil will no longer spam moodlet popup messages.
# Description Webedit ops. The changes to those events were balanced around the fact that all english downstreams had the glimmer changes early-merged, and were not reverted after the said glimmer changes were dropped. Now: - PsionicCatGotYourTongue occurs above 400 glimmer - FreeProber occurs above 300 - GlimmerRevenantSpawn occurs above 450 and burns a substantial amount of glimmer, giving epistemics a chance to recover - GlimmerMiteSpawn occurs above 250 - GlimmerRandomSentience occurs above 250 Not sure about NoosphericFry. I'm pretty sure probers no longer shoot lightnings, but I'm still opting in to keep it as it is, above 550 glimmer. # Changelog :cl: - tweak: Noospheric events should once again occur on lower glimmer levels. Signed-off-by: Mnemotechnican <[email protected]>
# Description - Fixes BeingActivelyPushed not resetting when pulling stops, resulting in entities who broke out of pulling being able to fall into trashcans and whatnot. - Makes it so that the puller does not receive impulse while pushing under gravity (as it turns out, it is, in fact, annoying when you are small) - Increases the default continuous push duration to 5 seconds to make pushing heavy objects easier. <details><summary><h1>Media</h1></summary> <p> https://github.com/user-attachments/assets/1808fb33-b9af-41b4-bec8-138eab088565 </p> </details> # Changelog :cl: - tweak: Pushing something no longer causes your character to move, but only if there is gravity holding you down. - tweak: Pushing an object with Ctrl-RMB now pushes it continuously for up to 5 seconds instead of 2.
github-actions
bot
added
Status: Needs Review
FoxxoTrystan
removed
Changes: C#
|
RSI Diff Bot; head commit 6044962 merging into 7c5455e Resources/Textures/Clothing/Back/etherealteleporter.rsi
Resources/Textures/Clothing/Eyes/Glasses/etherealgoogles.rsi
Resources/Textures/Clothing/OuterClothing/Misc/shadowkinrestraints.rsi
Resources/Textures/Interface/Actions/psionics.rsi
Resources/Textures/Interface/Actions/shadowkin_icons.rsi
|
FoxxoTrystan
added
Changes: C#
|
Will Re-Open PR with a new PR when #223 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Early Merge PR: Simple-Station/Einstein-Engines#960
Shadowkin disabled for normal players and mostly testing. (At first)
Require: #223
Changelog
🆑