Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rubyfang OC #396

Merged
merged 8 commits into from
Dec 7, 2024
Merged

Add Rubyfang OC #396

merged 8 commits into from
Dec 7, 2024

Conversation

Fansana
Copy link
Owner

@Fansana Fansana commented Dec 7, 2024

No description provided.

@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: C# Changes any cs files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files labels Dec 7, 2024
@Floof-Station-Bot Floof-Station-Bot changed the title add rubyfang oc Add Rubyfang Oc Dec 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2024 •
edited
Loading

RSI Diff Bot; head commit 708e739 merging into 70fe049
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Floof/Clothing/Neck/amulet_dragon.rsi

State Old New Status
equipped-NECK Added
icon Added

Edit: diff updated after 708e739

@Fansana Fansana changed the title Add Rubyfang Oc Add Rubyfang OC Dec 7, 2024
@FoxxoTrystan FoxxoTrystan added the Priority: 1-High Needs to be resolved as soon as possible label Dec 7, 2024
@FoxxoTrystan
Copy link
Collaborator

Il verify it and test it tomorrow, im sleepy!

FoxxoTrystan
FoxxoTrystan requested changes Dec 7, 2024
View reviewed changes
Copy link
Collaborator

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seem good in general except some code using outated method, suggestions provide the update ones.

Also OnUnEquipped Ensure the comp to check? instead use TryComp witch check if the user has the comp.

Content.Server/Polymorph/Components/PolymorphProviderComponent.cs Outdated Show resolved Hide resolved
Content.Server/Polymorph/Systems/PolymorphSystem.Provider.cs Outdated Show resolved Hide resolved
Content.Server/Polymorph/Systems/PolymorphSystem.Provider.cs Outdated Show resolved Hide resolved
Content.Server/Polymorph/Systems/PolymorphSystem.Provider.cs Outdated Show resolved Hide resolved
@FoxxoTrystan FoxxoTrystan added Status: Awaiting Changes Do not merge due to requested changes and removed Status: Needs Review Someone please review this labels Dec 7, 2024
Fansana and others added 6 commits December 7, 2024 11:05
@FoxxoTrystan FoxxoTrystan self-requested a review December 7, 2024 11:13
@github-actions github-actions bot added Status: Needs Review Someone please review this and removed Status: Awaiting Changes Do not merge due to requested changes labels Dec 7, 2024
@FoxxoTrystan FoxxoTrystan merged commit 0942002 into master Dec 7, 2024
11 checks passed
@FoxxoTrystan FoxxoTrystan mentioned this pull request Dec 7, 2024
Merged
@FoxxoTrystan
Copy link
Collaborator

Added to V7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoxxoTrystan FoxxoTrystan FoxxoTrystan approved these changes

@Memeji Memeji Memeji approved these changes

Assignees

@Fansana Fansana

Labels
Changes: C# Changes any cs files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files Priority: 1-High Needs to be resolved as soon as possible Status: Needs Review Someone please review this
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fansana @FoxxoTrystan @Memeji