Mass Bug Fixes

[Mnemotechnician]

Description

Did a pass to fix most bugs known to me.

Codewise changes:

• Rewrote the footprints system, mostly. The system now precisely keeps tracks of reagents collected from puddles, which prevents reagent duping or reagent vanishing (both of which were possible with the old system), and also allows to transfer more than 1 reagent at once, to transfer water with footprints, and (oh god) mix water with potassium on YOUR OWN FEET
• Leash system: fixed the bug that allowed you to set the length of a leash regardless of whether you can interact with it, and added additional examination text and popups.
• Standing state system: Fixed laying down near a table allowing you to bypass any windoors or walls blocking access to the said table.
• Carrying system: carrying an entity standing beside a table should no longer cause carring to enter a broken state.
• Fixed welders being able to weld while not lit
• Fixed instrument bands not being allowed to be created if there are any opaque entities between the band leader and the actor. (note: mobs, water tanks, closets, tables are all considered opaque. Now we are checking for opaque entities that have the occluder component, which actually makes them occlude light)
• Fixed deep fryer UI buttons not working due to it interpreting the deep fryer itself as the "user" instead of the entity interacting with the ui.
• Fixed lingering color flash effects from stamina and regular damage, caused by a race condition due to deferred component removal.

Yaml changes:

• Reparented ashtrays to BaseStorageItem, fixing the bug with them not having an openable storage UI.
• Added the Burnt tag to ash, so it can actually fit into ashtrays.
• Made table and counter frames climbable, so that the next 70 kg human to climb a glass table doesn't have to suffocate inside a wall, unable to climb or destroy the now-shattered table.

TODO (maybe as a follow-up PR):

• try to fix atmos equations to use pressure differential instead of mole count
• fix ActivatableUIRequiresPower allowing to bypass the power requirement for any UI when the maintenance panel is open (perhaps wizden has a fix for that one?)
• Fix linked mood effects (addictions, positive effect followed by a negative one) acting weirdly when a positive mood mood effect is added after the linked negative has taken place, resulting in a mood effect spam.
• Fix the "depressed" mood overlay flickering every few minutes.

Media

Footprints:

weeee-2025-01-03_04.41.09.mp4

Deep fryer:

weeee-2025-01-03_22.36.12.mp4

Color flash effects:

weeee-2025-01-03_23.58.27.mp4

Music bands:

---

Changelog

🆑

• tweak: Improved the footprints system to properly adhere to energy & mass conservation principles.
• fix: Fixed leash length settings and added popups to them.
• fix: Fixed lying down near a table allowing to bypass barriers.
• fix: Deep fryer and music band UIs should now work correctly.
• fix: Fixed lingering color effects from stamina and damage.
• fix: Minor fixes: made table frames climbable, made ashtrays work correctly, made welders require being lit in order to weld glass. See the PR Mass Bug Fixes #452 for more details.