Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pka Salvage Borg Changes #454

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

VividPups
Copy link
Contributor

@VividPups VividPups commented Jan 5, 2025

commit

Description

Salvage borg had no melee weapon and couldn't really used the pka due to the weapon angel angel-wielding requirement
this PR gives them a Survival knife (as told by floor)


Changelog

🆑

  • tweak: SESWC tinkered with the salvage borg PKA module and taped a knife to its other arm.

commit
@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: YML Changes any yml files labels Jan 5, 2025
@Floof-Station-Bot Floof-Station-Bot changed the title pka changes borg Pka Changes Borg Jan 5, 2025
@VividPups VividPups changed the title Pka Changes Borg Pka Salvage Borg changes Jan 5, 2025
@Floof-Station-Bot Floof-Station-Bot changed the title Pka Salvage Borg changes Pka Salvage Borg Changes Jan 5, 2025
Copy link
Contributor

@fenndragon fenndragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright so the sprites listed aren't actually necessary! you're overlapping some of the stuff from the parent and not adding states. one moment.

I WAS TOLD TO DO IT I SWEAR
Copy link
Contributor

@fenndragon fenndragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

at this point why am i here
@VividPups
Copy link
Contributor Author

There is one more thing I need to work one and that is to make the magnet for the ore bag work on the borg

@fenndragon
Copy link
Contributor

There is one more thing I need to work one and that is to make the magnet for the ore bag work on the borg

I am uncertain without looking if it's possible to make a bag magnet function without being worn... I will look

@VividPups
Copy link
Contributor Author

There is one more thing I need to work one and that is to make the magnet for the ore bag work on the borg

I am uncertain without looking if it's possible to make a bag magnet function without being worn... I will look

well so the Inderustal Process has a one so it might be as simple as making a new module or just adding something to the existing

@VividPups
Copy link
Contributor Author

VividPups commented Jan 8, 2025

There is one more thing I need to work one and that is to make the magnet for the ore bag work on the borg

I am uncertain without looking if it's possible to make a bag magnet function without being worn... I will look

Honestly I think there is a way there is some things I found in the VV however, I really don't want to go diving in it and would like this to be in with the update coming so I think I'm good with it now as I would like to focus on getting my other two PRs ready and done

@Mnemotechnician
Copy link
Collaborator

Looks alright now.

@Mnemotechnician Mnemotechnician merged commit 5ffbee8 into Fansana:master Jan 9, 2025
14 checks passed
Floof-Station-Bot added a commit that referenced this pull request Jan 9, 2025
@VividPups VividPups deleted the PKA-changes-for-borg branch January 15, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants