Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module Construction Update #472

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

fenndragon
Copy link
Contributor

Description

Changed the method and requirement of crafting security borg modules


Changelog

🆑

  • add: Added Security Modules to Security techfab
  • remove: removed original recipe for security modules

@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: YML Changes any yml files and removed Status: Needs Review Someone please review this labels Jan 9, 2025
Copy link
Collaborator

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, tho are the investigation module not finished?

Also do you allow me to add in this PR the cuffing system for BorgModuleStun or would you prefer it that i made it in my own PR?

Comment on lines -82 to -101
- type: entity
id: BaseSecModule
parent: BaseItem
name: blank security borg module
description: A piece of tech that gives cyborgs new abilities.
components:
- type: Item
storedRotation: -90
- type: Sprite
sprite: Floof/Objects/Specific/Robotics/borgmodule.rsi
layers:
- state: security
- type: StaticPrice
price: 100
- type: Tag
tags:
- BorgModuleGeneric
- type: GuideHelp
guides:
- Cyborgs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pray!

@FoxxoTrystan FoxxoTrystan added the Priority: 1-High Needs to be resolved as soon as possible label Jan 10, 2025
Copy link
Collaborator

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actully valid test fails:

Entitity WeaponBorgEnergyShotgun does not exist, but i supose this is coming from another PR.

/Prototypes/Entities/Structures/Machines/lathe.yml(649,7) BaseSecModule

@FoxxoTrystan FoxxoTrystan added the Status: Requires This requires something else to be done before being resolved label Jan 10, 2025
@FoxxoTrystan FoxxoTrystan self-requested a review January 10, 2025 06:34
@fenndragon
Copy link
Contributor Author

I like this, tho are the investigation module not finished?

Also do you allow me to add in this PR the cuffing system for BorgModuleStun or would you prefer it that i made it in my own PR?

oh if you want to add the cuffs to the stun module that would be great. the investigation module itself is fine, the problem was the construction recipe before

@github-actions github-actions bot added the Changes: C# Changes any cs files label Jan 10, 2025
@FoxxoTrystan FoxxoTrystan removed the Status: Requires This requires something else to be done before being resolved label Jan 10, 2025
@FoxxoTrystan FoxxoTrystan merged commit 33f7a1a into Fansana:master Jan 10, 2025
11 checks passed
Floof-Station-Bot added a commit that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files Priority: 1-High Needs to be resolved as soon as possible Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants