Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Surgeon stamp and outfit set #516

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

VividPups
Copy link
Contributor

@VividPups VividPups commented Jan 27, 2025

Description

Admin bell ask for it to be added. Has to do with the surgery update coming up

Media

image
image
image

Changelog

🆑

  • add: General Surgeon

ask to be added
@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files labels Jan 27, 2025
Copy link
Contributor

github-actions bot commented Jan 27, 2025

RSI Diff Bot; head commit d374484 merging into 477343f
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Floof/Clothing/Back/surgeongeneralsatchel.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/Floof/Clothing/Belts/surgeongeneralbelt.rsi

State Old New Status
equipped-BELT Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/Floof/Clothing/Departmental/Medical/surgeongeneralthong.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/Floof/Clothing/Head/Hoods/surgeongeneralhood.rsi

State Old New Status
equipped-HELMET Added
icon Added

Resources/Textures/Floof/Clothing/Head/surgeongeneralberet.rsi

State Old New Status
equipped-HELMET-hamster Added
equipped-HELMET Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/Floof/Clothing/Neck/surgeongeneralcloak.rsi

State Old New Status
equipped-NECK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/Floof/Clothing/OuterClothing/WinterCoats/coatsg.rsi

State Old New Status
equipped-OUTERCLOTHING-resomi Added
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/Floof/Objects/Misc/stamp.rsi

State Old New Status
stamp-sg Added

Edit: diff updated after d374484

Copy link
Collaborator

@Mnemotechnician Mnemotechnician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than those minor things, this is probably missing a new stamp state to be displayed on top of paper (see how other stamps do it, you will need to edit the original stamp RSI to achieve it).

However, that is optional, and you can omit it if you prefer to keep it generic.

@VividPups
Copy link
Contributor Author

Other than those minor things, this is probably missing a new stamp state to be displayed on top of paper (see how other stamps do it, you will need to edit the original stamp RSI to achieve it).

However, that is optional, and you can omit it if you prefer to keep it generic.

I was looking at that AND I try looking for it...had no idea what it does and where to find it

@Mnemotechnician
Copy link
Collaborator

I was looking at that AND I try looking for it...had no idea what it does and where to find it

The paper stamp sprites themselves are stored in bureaucracy.rsi (with state name in the form of paper_stamp-something). You can assign a visual state to a stamp via the stampState property of the Stamp component,

@VividPups
Copy link
Contributor Author

I was looking at that AND I try looking for it...had no idea what it does and where to find it

The paper stamp sprites themselves are stored in bureaucracy.rsi (with state name in the form of paper_stamp-something). You can assign a visual state to a stamp via the stampState property of the Stamp component,

but what does the stamp state do in opposite to not having one?

@VividPups VividPups marked this pull request as draft January 30, 2025 04:46
@VividPups
Copy link
Contributor Author

So the person that asked me to do this asked me to do more things like outfits because they will all be surgeon general surgeon things. I will probably make an outfit set. Right now I am just filling in outfit things that SHE wears. if more are wanted after Ill start adding more to the set. I see this being more of an Admin thing. since CMO can perform surgery

@VividPups VividPups changed the title General Surgeon stamp General Surgeon stamp and outfit set Jan 30, 2025
@Mnemotechnician
Copy link
Collaborator

but what does the stamp state do in opposite to not having one?

Not much, just a different visual mark on stamped paper. You can omit it if you'd like.

As for other clothing, I personally have nothing against it, so long as the admin team is fine with it.

@VividPups
Copy link
Contributor Author

If the admin team would like more clothing style for...I guess a more unique look as being CC I don't mind doing more to it However, I am trying to get an "setoutfit" but I don't know how to make it I think...I need to make it a job to make it an outfit ?

update two
add the set job, pda, and ID
@VividPups VividPups marked this pull request as ready for review January 30, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants